Closed Bug 1009408 Opened 11 years ago Closed 11 years ago

IAC shouldn't check the install origin for certified apps

Categories

(Core :: DOM: Device Interfaces, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: airpingu, Assigned: airpingu)

References

Details

Attachments

(2 files)

The certified app doesn't have an install origin, so the IAC shouldn't check if it matches the rules.
I'd like to remove the install origin check in the Gaia UI test because both the publisher and subscriber apps are certified, which means the |installOrigins| won't actually work for them. Since the IAC is exposed to certified apps only so the test is actually enough for now. Note that we need to land the Gaia part first and then we can land the Gecko part to ensure the backward compatibility.
Attachment #8421615 - Flags: review?(ferjmoreno)
It doesn't make sense to match the install origin for certified apps because they don't have ones, so I'd like remove the logic to meet what's said in the spec [1]: "Since certified apps has not a valid install origin, these constraint does not apply to them." [1] https://wiki.mozilla.org/WebAPI/Inter_App_Communication_Alt_proposal
Attachment #8421618 - Flags: review?(ferjmoreno)
Attachment #8421615 - Flags: review?(ferjmoreno) → review+
Attachment #8421618 - Flags: review?(ferjmoreno) → review+
There are going to be some conflicts with bug 951246. Will rebase this tomorrow. Thanks Fernando for the review!
Keywords: checkin-needed
Whiteboard: NOTE! We have to land the part-1 patch on Gaia first. After it lands Central/Try then we can land the part-2 patch on Gecko, so that we won't break the Gaia UI Test (Gu) on the try server.
Keywords: checkin-needed
Whiteboard: NOTE! We have to land the part-1 patch on Gaia first. After it lands Central/Try then we can land the part-2 patch on Gecko, so that we won't break the Gaia UI Test (Gu) on the try server.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: