Noemí Freire (:noemi) Reporter
	Description • 10 years ago

Description:
"X" icon lost when accessing to Messages Settings screen

STRs:
1- Tap on Messaging app
2- Tap on "..." icon
3- Select "Settings"

ACTUAL RESULT:
Messaging Settings screen is shown but "X" icon is not appearing. Notice that if you tap on the area in which "X" icon is expected to be the Messaging Settings screen is closed and you go back to Messaging app

EXPECTED RESULT:
Messaging Settings screen is shown and "X" icon appears so users can select it to go back to Messaging app

It occurs on today's (5/13) master build:
Device: Hamachi
Gecko: df91ea9
Gaia: 4c8c9c1
BuildId: 20140513070029
Platform version: 32.0a1

It does NOT occur on today's (5/13) v1.4 build:
Device: Hamachi
BuildId: 20140513053310
Gecko: 2d6c496
Gaia: b40103d
Platform version: 30.0

	Joshua Mitchell (Inactive)
	Comment 2 • 10 years ago

B2G Inbound Regression Window:

Last Working:
Environmental Variables:
Device: Buri 
BuildID: 20140512125358
Gaia: e8a1eedb848382323254edbd234baecebc5dc5ca
Gecko: 3c090ccefb70
Version: 32.0a1
Firmware Version: v1.2-device.cfg

First Broken:
Environmental Variables:
Device: Buri
BuildID: 20140512133556
Gaia: 2f89c43e798ccba631025bedc47a1fb24e830cf2
Gecko: 86e58070041f
Version: 32.0a1
Firmware Version: v1.2-device.cfg

Last Working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: e8a1eedb848382323254edbd234baecebc5dc5ca
Gecko: 86e58070041f

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: 2f89c43e798ccba631025bedc47a1fb24e830cf2
Gecko: 3c090ccefb70


Gaia pushlog: https://github.com/mozilla-b2g/gaia/compare/e8a1eedb848382323254edbd234baecebc5dc5ca...2f89c43e798ccba631025bedc47a1fb24e830cf2

	Jason Smith [:jsmith]
	Comment 3 • 10 years ago

Maybe caused by bug 1006118?

Wilson - What do you think?

	Julien Wajsberg [:julienw]
	Comment 4 • 10 years ago

Could also be bug 973456.

	Wilson Page [:wilsonpage]
	Comment 5 • 10 years ago

jsmith: The <gaia-header> component has landed on master, but has not been rolled out onto any apps as of yet. This is due to pending shadow-dom platform fixes.

	Jason Smith [:jsmith]
	Comment 6 • 10 years ago

(In reply to Julien Wajsberg [:julienw] from comment #4)
> Could also be bug 973456.

Arthur - What do you think?

	Arthur Chen [:arthurcc][inactive after 6/30]
	Comment 7 • 10 years ago

I believe this issue was regressed by this commit[1], in which the image was replaced but the path in settings app was not accordingly.

[1] https://github.com/mozilla-b2g/gaia/commit/1ca200f8d8e764dfe315274c5c168e4ac0bd3733

	Jason Smith [:jsmith]
	Comment 8 • 10 years ago

(In reply to Arthur Chen [:arthurcc] from comment #7)
> I believe this issue was regressed by this commit[1], in which the image was
> replaced but the path in settings app was not accordingly.
> 
> [1]
> https://github.com/mozilla-b2g/gaia/commit/
> 1ca200f8d8e764dfe315274c5c168e4ac0bd3733

Ok.

Arnau - Can you take a look?

	Arthur Chen [:arthurcc][inactive after 6/30]
	Comment 9 • 10 years ago

Evelyn, could you help check this small patch? Thanks.

	Arnau March [:arnau] ( not working in Firefox OS anymore :( ) Assignee
	Comment 10 • 10 years ago

Sorry guys, as part of bug 1005802, I forgot to replace this link from SVG to PNG.

	Arnau March [:arnau] ( not working in Firefox OS anymore :( ) Assignee
	Comment 12 • 10 years ago

Merged: 29024d50688edcff59b5e71e8e1a931ad231d643