Closed Bug 1009459 Opened 10 years ago Closed 10 years ago

[NFC][Bluetooth] Sender show "File could not be sent" message when NFC share file successfully

Categories

(Firefox OS Graveyard :: NFC, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:2.0+, b2g-v2.0 verified, b2g-v2.1 verified)

VERIFIED FIXED
2.0 S6 (18july)
blocking-b2g 2.0+
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- verified

People

(Reporter: ashiue, Assigned: arno)

References

Details

Attachments

(6 files)

Attached image S__712709.jpg (deleted) —
Gaia 2f89c43e798ccba631025bedc47a1fb24e830cf2 Gecko https://hg.mozilla.org/mozilla-central/rev/4b6d63b05a0a BuildID 20140512160204 Version 32.0a1 Device Nexus 4 STR: 1. launch "settings" app for 2 phones 2. turn on "NFC" for 2 phones 3. turn off "bluetooth" for phones 4. device A share image via NFC to device B (device B receive successfully) 5. device B share image via NFC to device A (device A receive successfully) 6. repeat step 4 and step 5 more the 3 times Expected result: File transfer without any problem Actual result: Even NFC share file successfully, sender will show "File could not be sent" message.
Attached file sender_nfc.log (deleted) —
Ben, can you please comment this bug?
Flags: needinfo?(btian)
It seems NFC on receiver turns off BT before the last ack is received by sender. When sender sends out the last data packet, it expects the last ack from receiver and then notifies gaia of transfer success. However in this bug BT connection is closed before sender receives the last ack, so => receiver pops success because it gets the last data packet, while => sender pops failure because it doesn't get the last ack before BT connection is closed. I cannot reproduce this bug after reverting bug 1002304's change.
Flags: needinfo?(btian)
Arno, can you comment on this? Have you tried you patch in Bug 1002304? Also ni? to Ken, this bug blocks the sharing feature of NFC, I'd like to ask to backout the patch in Bug 1002304 and reopen it.
Flags: needinfo?(kchang)
Flags: needinfo?(arno)
(In reply to Yoshi Huang[:allstars.chh] from comment #4) > Also ni? to Ken, this bug blocks the sharing feature of NFC, I'd like to ask > to backout the patch in Bug 1002304 and reopen it. Thanks, Yoshi. Please do it. This bug is worse than Bug 1002304.
Flags: needinfo?(kchang)
(In reply to Ken Chang[:ken] from comment #5) Sorry, after discussed with Alison, (and she also mentioned in STR #6 from Comment 0), this bug will happen after repeating step 4 and step 5 more the 3 times. This seems to be some timing bug in either NFC or BT, and is not directly related to Bug 1002304. So I won't reopen Bug 1002304.
This bug is related to the race condition discussed in bug 998175. The patch for bug 998175 should also fix this issue and it should be marked as a duplicate.
Flags: needinfo?(arno)
blocking-b2g: --- → backlog
This bug could be easily reproduced, thus user could see the incorrect message easily. I think this case should fix in 2.0, could promote this bug to blocking-b2g 2.0 issue?
blocking-b2g: backlog → 2.0?
Please fix this for 2.0, Quality of experience issue.
blocking-b2g: 2.0? → 2.0+
Per comment #7, fixed by bug 998175, which should block if this does.
Depends on: 998175
Per comment 7. Please verify after bug 998175 is fixed.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Verified on Gaia db0358b53488a941ced352d890802342d7ced00e Gecko https://hg.mozilla.org/releases/mozilla-aurora/rev/0874ec920408 BuildID 20140715160201 Version 32.0a2
Status: RESOLVED → VERIFIED
Resolution: DUPLICATE → FIXED
Assignee: nobody → arno
Target Milestone: --- → 2.0 S6 (18july)
Attached video verify_video.MP4 (deleted) —
Hi Hubert, Could you help with it, thanks. This issue has been verified successfully on Flame v2.1. And this issue has been verified unsuccessfully on Flame v2.0 STR: 1. Launch "settings" app for 2 phones. 2. Turn on "NFC" for 2 phones. 3. Turn off "bluetooth" for phones. 4. Device A share image via NFC to device B (device B receive successfully). 5. Device B share image via NFC to device A (device A receive successfully). 6. Repeat step 4 and step 5 more the 3 times. **Flame 2.1 could send and receive file successfully everytime. **Flame 2.0 will display "File could not be sent" after repeat step 4 and step 5 several times. Found time: See attachment: verify_video.MP4 and Flame 2.0_File could not be sent.png and logcat_Flame2.0.txt Flame 2.1 reproducing rate: 0/5 Flame 2.0 reproducing rate: 1/4 Flame 2.0 versions: Gaia-Rev 8d1e868864c8a8f1e037685f0656d1da70d08c06 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3 Build-ID 20141202000201 Version 32.0 Device-Name flame FW-Release 4.4.2 FW-Incremental eng.cltbld.20141202.034707 FW-Date Tue Dec 2 03:47:18 EST 2014 Bootloader L1TC00011880 Flame 2.1 versions: Gaia-Rev ccb49abe412c978a4045f0c75abff534372716c4 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22 Build-ID 20141202001201 Version 34.0 Device-Name flame FW-Release 4.4.2 FW-Incremental eng.cltbld.20141202.034824 FW-Date Tue Dec 2 03:48:34 EST 2014 Bootloader L1TC00011880
Flags: needinfo?(hlu)
Attached image screenshot of flame 2.0 (deleted) —
Attached file logcat of Flame 2.0 (deleted) —
Good. Thanks for the verification. NI?whsu to follow up
Flags: needinfo?(hlu) → needinfo?(whsu)
Hi, Sue, May I have your help? Please verify this bug on latest v2.0 build (v188 base image) again. If you still can reproduce this bug, please submit a new bug and note bug number here. Many thanks.
Flags: needinfo?(whsu) → needinfo?(lulu.tian)
Attached video verify_v2.0.MP4 (deleted) —
This issue is verified not happen in latest build of Flame 2.0(v188 base image). Both of device A and device B can sent and receive image successfully. See attachment: verify_v2.0.MP4 Rate:0/10 Flame 2.0 build: Gaia-Rev 31d6c9422cd0a8213df9f96019c9ab7168ec3ab3 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/7c7daab470fb Build-ID 20150108000200 Version 32.0 Device-Name flame FW-Release 4.4.2 FW-Incremental eng.cltbld.20150108.034549 FW-Date Thu Jan 8 03:46:00 EST 2015 Bootloader L1TC00011880
Flags: needinfo?(lulu.tian)
(In reply to Sue from comment #18) > Created attachment 8546331 [details] > verify_v2.0.MP4 > > This issue is verified not happen in latest build of Flame 2.0(v188 base > image). Both of device A and device B can sent and receive image > successfully. > See attachment: verify_v2.0.MP4 > Rate:0/10 > > Flame 2.0 build: > Gaia-Rev 31d6c9422cd0a8213df9f96019c9ab7168ec3ab3 > Gecko-Rev > https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/7c7daab470fb > Build-ID 20150108000200 > Version 32.0 > Device-Name flame > FW-Release 4.4.2 > FW-Incremental eng.cltbld.20150108.034549 > FW-Date Thu Jan 8 03:46:00 EST 2015 > Bootloader L1TC00011880 Hi, Sue, Thanks so much. Have a nice weekend!
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: