Closed Bug 1009473 Opened 11 years ago Closed 11 years ago

Polish image list view

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox30 verified, firefox31 verified, firefox32 verified)

VERIFIED FIXED
Firefox 32
Tracking Status
firefox30 --- verified
firefox31 --- verified
firefox32 --- verified

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(2 files)

Right now images are too small, let's remove the padding around them to make them bigger.
Attachment #8421806 - Flags: review?(lucasr.at.mozilla)
This is the color antlam gave me, and it's not used elsewhere in the product, but maybe we should pull it into dimens.xml, or file a follow-up to audit the different shades of gray that we use in the product.
Attachment #8421809 - Flags: review?(lucasr.at.mozilla)
Attachment #8421806 - Flags: review?(lucasr.at.mozilla) → review+
Attachment #8421809 - Flags: review?(lucasr.at.mozilla) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Depends on: 1012195
Comment on attachment 8421806 [details] [diff] [review] Remove padding around list item images I know we're getting late in the beta cycle, but I think this would be a really nice fix to have before we start promoting hub add-ons in Fx30. [Approval Request Comment] Bug caused by (feature/regressing bug #): new home panel APIs User impact if declined: home panel lists look uglier Testing completed (on m-c, etc.): landed on m-c 5/13 Risk to taking this patch (and alternatives if risky): low risk, style tweaks to dynamic panel lists String or IDL/UUID changes made by this patch: none
Attachment #8421806 - Flags: approval-mozilla-beta?
Attachment #8421806 - Flags: approval-mozilla-aurora?
Comment on attachment 8421806 [details] [diff] [review] Remove padding around list item images it's less 'late' in the beta cycle for mobile as we have two more betas and this is a low risk user-facing style fix on a great new feature so let's take it.
Attachment #8421806 - Flags: approval-mozilla-beta?
Attachment #8421806 - Flags: approval-mozilla-beta+
Attachment #8421806 - Flags: approval-mozilla-aurora?
Attachment #8421806 - Flags: approval-mozilla-aurora+
Verified fixed on: Device: LG Nexus 4 (Android 4.4.2) Builds: 32.0a1 Nightly 05/26 and 31.0a2 Aurora 04/26
Verified fixed on Firefox 30 Beta 8
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: