Closed Bug 1010025 Opened 10 years ago Closed 10 years ago

Add integration test to cover 3rd-party IME Switching

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.0 S4 (20june)

People

(Reporter: rudyl, Assigned: rudyl)

References

Details

(Whiteboard: [p=2])

Attachments

(1 file)

Patch V1 - pull request 19619
(deleted), text/x-github-pull-request
evanxd
: review+
Details
+++ This bug was initially created as a clone of Bug #1010021 +++ After IME installation, 1. Switch to 3rd-party app/layout by pressing "Globe key" 2. Switch to 3rd-party app/layout by long pressing "Globe key" and select one from the IME menu. 3. Drag down the utility tray, could access the IME switching function.
No longer blocks: vkb-integration
Take it and this should not depends installation test, we could install a app with marionette js client first and then do the swicthing tests.
Assignee: nobody → rlu
No longer depends on: 1010021
Start to working on this.
Status: NEW → ASSIGNED
Whiteboard: [p=2]
Target Milestone: --- → 2.0 S3 (6june)
WIP here and start to do the stability check with this pr, https://github.com/mozilla-b2g/gaia/pull/19638
Attached file Patch V1 - pull request 19619 (deleted) —
Evan, could you please help review this one? Thanks in advance. :) -- Stability check has passed, here is the result, https://github.com/mozilla-b2g/gaia/pull/19638
Attachment #8429101 - Flags: review?(evanxd)
Comment on attachment 8429101 [details] Patch V1 - pull request 19619 Hi Rudy, Could we do the stability check before we review the patch? Thanks.
Attachment #8429101 - Flags: review?(evanxd)
Flags: needinfo?(rlu)
Attachment #8429101 - Flags: review?(evanxd)
(In reply to Evan Tseng [:evanxd][:愛聞插低] from comment #5) > Comment on attachment 8429101 [details] > Patch V1 - pull request 19619 > > Hi Rudy, > > Could we do the stability check before we review the patch? > > Thanks. Yes, sure. Stability check has passed, here is the result, https://github.com/mozilla-b2g/gaia/pull/19638
Flags: needinfo?(rlu)
Hi Rudy, I will review the patch this week, and hope we could land it this week. Sorry for that, I was busy on some marionette things last week.
Hi Rudy, I added comments for the patch on GitHub.
Flags: needinfo?(rlu)
Comment on attachment 8429101 [details] Patch V1 - pull request 19619 Patch updated to address the review comments. - Separate system app related part to lib/system.js - Move DOM element getters to the top. You may refer to this commit for the above changes, https://github.com/RudyLu/gaia/commit/26e946078de2d33bb32825c2b71e7168391d4a5d#diff-0 And please note that most of the original code in lib/keyboard.js is is lib/system.js now. Thanks.
Flags: needinfo?(rlu)
Comment on attachment 8429101 [details] Patch V1 - pull request 19619 Hi Rudy, Nice work!
Attachment #8429101 - Flags: review?(evanxd) → review+
Landed to Gaia master, https://github.com/mozilla-b2g/gaia/commit/66728baa3e1da97d9c12936d0cf6a11a112636be Evan, thanks for the review.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: 2.0 S3 (6june) → 2.0 S4 (20june)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: