Closed
Bug 1010096
Opened 10 years ago
Closed 10 years ago
Display add-ons in alphabetical order in about:addons
Categories
(Firefox for Android Graveyard :: Add-on Manager, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 32
People
(Reporter: Margaret, Assigned: lviknesh)
Details
(Whiteboard: [mentor=margaret][lang=js][good first bug])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Margaret
:
review+
|
Details | Diff | Splinter Review |
The (lack of) logic for this is here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/aboutAddons.js#243
|
||
Updated•10 years ago
|
Assignee: nobody → eedens
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8427734 -
Flags: review?(margaret.leibovic)
|
Reporter | |
Comment 3•10 years ago
|
||
Comment on attachment 8427734 [details] [diff] [review]
addon.patch
Review of attachment 8427734 [details] [diff] [review]:
-----------------------------------------------------------------
Excellent! I just have one small style comment for you to address. You should upload a new version of the patch that addresses that, and then you can set the checkin-needed keyword on the bug for someone to come commit it for you! :)
::: mobile/android/chrome/content/aboutAddons.js
@@ +247,5 @@
> let list = document.getElementById("addons-list");
> list.innerHTML = "";
>
> + aAddons.sort(function(a,b) {
> + return a.name.localeCompare(b.name);
Nit: We use 2-space indentation in our JavaScript code.
Attachment #8427734 -
Flags: review?(margaret.leibovic) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Attachment #8427734 -
Attachment is obsolete: true
Attachment #8427977 -
Flags: review?(margaret.leibovic)
Attachment #8427977 -
Flags: checkin?
|
|
Reporter | |
Comment 5•10 years ago
|
||
Comment on attachment 8427977 [details] [diff] [review]
addon-updated.patch
Review of attachment 8427977 [details] [diff] [review]:
-----------------------------------------------------------------
Great! I also should have mentioned that we generally only use the checkin flag on patches if there is a large series of patches in a bug that are landing incrementally. Instead, we use a keyword on the bug. Confusing, I know!
Attachment #8427977 -
Flags: review?(margaret.leibovic)
Attachment #8427977 -
Flags: review+
Attachment #8427977 -
Flags: checkin?
|
|
Reporter | |
Updated•10 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 6•10 years ago
|
||
Yeah got it ;)
|
||
Comment 7•10 years ago
|
||
Whiteboard: [mentor=margaret][lang=js][good first bug] → [mentor=margaret][lang=js][good first bug][fixed-in-fx-team]
|
|
||
Updated•10 years ago
|
Keywords: checkin-needed
|
|
||
Comment 8•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [mentor=margaret][lang=js][good first bug][fixed-in-fx-team] → [mentor=margaret][lang=js][good first bug]
Target Milestone: --- → Firefox 32
|
||
Comment 9•10 years ago
|
||
Add-ons are in an alphabetical order in about:addons, so:
Verified fixed on:
Device: LG Nexus 4 (Android 4.4.2)
Build: Firefox for Android 32.0a1 (2014-05-27)
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•