Closed Bug 1010259 Opened 11 years ago Closed 9 years ago

[highlighter] Highlighter is incompatible with FirefoxOS 1.3 and lower

Categories

(DevTools :: Inspector, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: sole, Unassigned)

Details

Attachments

(1 file)

Attached image inspect.gif (deleted) —
1) while the normal behaviour of the inspect mode is to highlight elements in the tree as you hover with the mouse in a normal page, when you try to inspect things in the simulator you can only get the elements highlighted if you *CLICK* on them 2) another inconsistency is that the inspect button keeps being highlighted or "active" forever until you close AppManager, seems like there's no way to reset it to "not inspecting" mode just as you can do in "normal desktop" inspection
Summary: "Inspect" button behaves inconsistently when used in AppManager → [appmgr v2] "Inspect" button behaves inconsistently when used in AppManager
(In reply to Soledad Penades [:sole] [:spenades] from comment #0) > Created attachment 8422451 [details] > inspect.gif > > 1) while the normal behaviour of the inspect mode is to highlight elements > in the tree as you hover with the mouse in a normal page, when you try to > inspect things in the simulator you can only get the elements highlighted if > you *CLICK* on them That's normal. It's because on device (so in a simulator too) there's no "hover" mode. We I guess we could work around that. But I don't think it's worth it. > 2) another inconsistency is that the inspect button keeps being highlighted > or "active" forever until you close AppManager, seems like there's no way to > reset it to "not inspecting" mode just as you can do in "normal desktop" > inspection Now that's bad. I can reproduce too. Patrick, could you look at this? Might be related to bug 1016331.
(this is not specific to the new app manager)
No longer blocks: enable-webide
I tested with nightly (with the current app manager) and both 1.4 and 2.0 simulators, and it worked fine. I was able to start/stop the picker by clicking on the button, and hovering over the simulator with the mouse did show the outline. Is there anything special I need to do to reproduce this bug? Could have been fixed since then by another bug.
Sorry, I just realized the simulator used in the gif was 1.3, so I tested with it and was able to reproduce both problems. unrecognizedPacketType errors are output to the console while inspecting an app. This looks like a backward compatibility issue between the client toolbox and the actors in the 1.3 simulator.
Problems start to appear after an app reload.
Last good revision: f073b3d6db1f (2014-03-14) First bad revision: 82c90c17fc95 (2014-03-15) Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f073b3d6db1f&tochange=82c90c17fc95
A good (and I think the only) candidate for this regression is bug 663778, which is when we implemented the box-model highlighter. Although it's not used on B2G, we must have changed something that prevents the highlighter from working with simulator 1.3. This has been broken since mid March! Is anyone still using the simulator 1.3?
Summary: [appmgr v2] "Inspect" button behaves inconsistently when used in AppManager → Highlighter pick button behaves inconsistently when used in AppManager
Component: Developer Tools: App Manager → Developer Tools: Inspector
(In reply to Patrick Brosset [:pbrosset] [:patrick] from comment #7) > This has been broken since mid March! Is anyone still using the simulator 1.3? Yes. This will be next major version in the market.
Re-phrasing the summary. Bug 663778 is where we landed the new box-model highlighter and that bug most probably caused our toolbox to not be compatible with FirefoxOS devices and simulator running 1.3 or lower anymore. In that bug, there's been a few actor's interface changes (inspectorActor and highlighterActor) which are probably the reason why the toolbox (embedded in the appmanager) can't properly pick elements anymore. It does somehow work, making this a non critical bug, but it's kind of weird. The pick icon won't toggle off for instance, and the whole highlighter looks like it's broken. The other thing is that this started to appear in Firefox 30 which is about to hit release next week. So if we *really* want to fix this all the way, we'd have to do a lot of uplifting.
Summary: Highlighter pick button behaves inconsistently when used in AppManager → [highlighter] Highlighter is incompatible with FirefoxOS 1.3 and lower
A shorter regression range: Last good revision: e673315c346f First bad revision: e4880e7935a6 Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e673315c346f&tochange=e4880e7935a6 Definitely shows bug 663778 as the culprit.
WONTFIX ?
Flags: needinfo?(pbrosset)
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(pbrosset)
Resolution: --- → WONTFIX
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: