Closed
Bug 1010553
Opened 11 years ago
Closed 11 years ago
Create a gaia-switch web component
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(b2g-v2.0 fixed)
RESOLVED
FIXED
2.0 S2 (23may)
Tracking | Status | |
---|---|---|
b2g-v2.0 | --- | fixed |
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
(Whiteboard: [p=3],[systemsfe])
Attachments
(1 file)
A gaia switch web component would be useful to have. I would like to take this and start experimenting with web components.
Assignee | ||
Comment 1•11 years ago
|
||
Mostly WIP - but please feel free to add any comments if you have them.
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 8422736 [details]
Github pull request
Hey Guys!
Thought I'd give a component a shot here. Please take a look and let me know what you think. I copied most of the comment blocks from the gaia-header component as we are waiting on the same platform issues for most of these.
Attachment #8422736 -
Flags: review?(yor)
Attachment #8422736 -
Flags: review?(wilsonpage)
Attachment #8422736 -
Flags: review?(21)
Comment 4•11 years ago
|
||
kgrandon: Love it! Couple of nits, most importantly making sure web-component styling is standalone/decoupled from old building block.
Assignee | ||
Updated•11 years ago
|
Alias: gaia-switch
Comment 5•11 years ago
|
||
Comment on attachment 8422736 [details]
Github pull request
Nice that we have broken free from BB :)
Looks to me like the PNGs could be ditched at some point. No reason why those can't be done with pure CSS removing all the @2x crap, plus would make them 'themeable' :)
Attachment #8422736 -
Flags: review?(wilsonpage) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 8422736 [details]
Github pull request
+1 to getting rid of PNGs, let's definitely try to do that in the future :)
Thanks for the review. I'd like to move fast on this stuff, so going to land. If you guys have any other feedback we can address it.
Attachment #8422736 -
Flags: review?(yor)
Attachment #8422736 -
Flags: review?(21)
Assignee | ||
Comment 7•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
status-b2g-v2.0:
--- → fixed
Target Milestone: --- → 2.0 S2 (23may)
Assignee | ||
Comment 8•11 years ago
|
||
Landed a follow-up to move tests to mirror elements folder as we will be landing several of these:
https://github.com/mozilla-b2g/gaia/commit/2a7ee1d0777ddafd2df31b7779be578d3f0dcbae
Updated•11 years ago
|
Blocks: gaia-switch
Updated•11 years ago
|
Assignee | ||
Comment 9•11 years ago
|
||
I landed a small commit as a follow-up to rename the gaia-switch file paths to be gaia_switch.
https://github.com/mozilla-b2g/gaia/commit/b53f4a8c02722423ef17aacf9c6cce5c2276a23a
You need to log in
before you can comment on or make changes to this bug.
Description
•