Closed
Bug 1010568
Opened 10 years ago
Closed 10 years ago
Remove usage of 2nd WeakMap#get parameter from TelemetryStopwatch
Categories
(Firefox Health Report Graveyard :: Client: Desktop, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 32
People
(Reporter: Swatinem, Assigned: Swatinem)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
Patch coming as soon as I got some time…
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8423134 -
Flags: review?(felipc)
|
||
Comment 2•10 years ago
|
||
Why? Did this API change? I see there are two tests testing the exact opposite behavior: http://mxr.mozilla.org/mozilla-central/source/js/src/tests/js1_8_5/extensions/weakmap.js?force=1#89 http://mxr.mozilla.org/mozilla-central/source/dom/imptests/html/js/builtins/test_WeakMap.prototype-properties.html?force=1#95 So I don't know what to believe anymore. My own testing shows that the second param is still valid.
|
|
Assignee | |
Comment 3•10 years ago
|
||
Yes, the API did change, they removed it from the ES6 spec. Dependent bug 1009349 is about that. Guess thats the price we have to pay for using experimental features :-)
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8423134 [details] [diff] [review] stopwatch.patch Review of attachment 8423134 [details] [diff] [review]: ----------------------------------------------------------------- Ok thanks :)
Attachment #8423134 -
Flags: review?(felipc) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e53692a840f
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6e53692a840f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
|
||
Updated•6 years ago
|
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•