Closed Bug 1010741 Opened 11 years ago Closed 10 years ago

Toolbar refinement - Change text style in toolbar and search hint in about:home

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect)

Product:
Firefox for Android Graveyard
Component:
Awesomescreen
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 34

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

Attachments

(4 files, 1 obsolete file)

URLbar_mock1.png
(deleted), image/png
Details
icon_search.zip
(deleted), application/zip
Details
Change text appearance in toolbar (r=mcomella)
(deleted), patch
mcomella
: review+
Details | Diff | Splinter Review
Change toolbar hint to "Search or enter address" (r=margaret)
(deleted), patch
Margaret
: review+
Details | Diff | Splinter Review
No description provided.
Attached image URLbar_mock1.png (deleted) —
Font: Roboto light, vertically centered, size 42 (at XXHDPI), 14 sp Alignment: padded 20px (at XXHDPI) from the icon to the left, 7 dp Font fallback: Roboto regular Color: #777777
Attached file icon_search.zip (deleted) —
Search icons attached at MDPI, HDPI, XHDPI, XXHDPI
Attachment #8471541 - Flags: review?(margaret.leibovic)
Attachment #8471537 - Flags: review?(michael.l.comella)
Attachment #8471541 - Flags: review?(margaret.leibovic) → review+
FYI: I'm going to implement the search icon change in a follow-up (bug 1054268).
Attached patch Show search icon in about:home (r=margaret) (obsolete) (deleted) — — Splinter Review
Comment on attachment 8473688 [details] [diff] [review] Show search icon in about:home (r=margaret) Wrong bug.
Attachment #8473688 - Attachment is obsolete: true
Summary: Toolbar refinement - Show search icon and change text hint in about:home → Toolbar refinement - Change text style in toolbar and search hint in about:home
Kudos to you for having the guts to land a giant stack of patches like this on a Friday night, but unfortunately I had to back it all out for robocop failures. https://hg.mozilla.org/integration/fx-team/rev/d18d3e14ac3e https://tbpl.mozilla.org/php/getParsedLog.php?id=46051162&tree=Fx-Team
Also appears to have made robocop-1 basically perma-fail as well.
The string changes in this bug caused the failures. Forgot to update the tests accordingly. Try build looks nice and green now, pushed: https://hg.mozilla.org/integration/fx-team/rev/a22c03c7a4c0 https://hg.mozilla.org/integration/fx-team/rev/45ed18e439d1
https://hg.mozilla.org/mozilla-central/rev/a22c03c7a4c0 https://hg.mozilla.org/mozilla-central/rev/45ed18e439d1
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: