Closed
Bug 1011116
Opened 10 years ago
Closed 10 years ago
Project Editor: After folder is selected in file tree, the file does not get reselected when editor is focused
Categories
(DevTools Graveyard :: WebIDE, defect)
DevTools Graveyard
WebIDE
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 34
People
(Reporter: jryans, Assigned: bgrins)
References
Details
Attachments
(1 file)
(deleted),
patch
|
harth
:
review+
jryans
:
feedback+
|
Details | Diff | Splinter Review |
STR:
1. Open AMv2 with Itchpad
2. Select a file (it's displayed in the editor)
3. Select a folder (your file is still from step 2 is still displayed)
4. Click into the file editor
ER:
I would expect the file to be re-selected in the tree, since I have now actively switched to the editor. Otherwise, some random folder is selected, and there is no other display of the file name or path of what's shown in the editor.
AR:
The folder from step 3 remains selected.
Assignee | ||
Comment 1•10 years ago
|
||
(In reply to J. Ryan Stinnett [:jryans] from comment #0)
> I would expect the file to be re-selected in the tree, since I have now
> actively switched to the editor. Otherwise, some random folder is selected,
> and there is no other display of the file name or path of what's shown in
> the editor.
I agree with your expected results, and think we should update it. In general, there is also a case that the top status bar that was displaying the file name would be helpful (http://i.imgur.com/ibeuSqv.png vs http://i.imgur.com/tSRCq5p.png). Paul wanted these removed to clean up the UI a bit (https://bugzilla.mozilla.org/show_bug.cgi?id=987089#c52), so they are hidden with CSS, but I think there is a case for leaving one or both.
Assignee | ||
Updated•10 years ago
|
Summary: Itchpad: Syncing file tree strange when folder selected → Itchpad: After folder is selected in file tree, the file does not get reselected when editor is focused
Assignee | ||
Comment 2•10 years ago
|
||
Is this what you are thinking?
Reporter | ||
Comment 3•10 years ago
|
||
Comment on attachment 8460993 [details] [diff] [review]
editor-tree-selection.patch
Review of attachment 8460993 [details] [diff] [review]:
-----------------------------------------------------------------
This looks good to me, thanks!
Attachment #8460993 -
Flags: feedback?(jryans) → feedback+
Assignee | ||
Updated•10 years ago
|
Attachment #8460993 -
Flags: review?(fayearthur)
Assignee | ||
Updated•10 years ago
|
Summary: Itchpad: After folder is selected in file tree, the file does not get reselected when editor is focused → Project Editor: After folder is selected in file tree, the file does not get reselected when editor is focused
Comment 4•10 years ago
|
||
Comment on attachment 8460993 [details] [diff] [review]
editor-tree-selection.patch
Review of attachment 8460993 [details] [diff] [review]:
-----------------------------------------------------------------
I like the idea of some kind of file name display too.
Attachment #8460993 -
Flags: review?(fayearthur) → review+
Assignee | ||
Comment 5•10 years ago
|
||
> I like the idea of some kind of file name display too.
Yes, me too. Paul originally voiced this concern about the 2 status bars taking up too much space in https://bugzilla.mozilla.org/show_bug.cgi?id=987089#c52. If the concern is taking up too much space, maybe we could have a single status bar at the bottom that shows line:col / file name / syntax mode, etc. Would have to play with it a bit but seems like it would be useful.
Assignee | ||
Comment 6•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 7•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 8•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
QA Whiteboard: [qa-]
QA Whiteboard: [qa-] → [qa+]
Comment 9•10 years ago
|
||
Verified as fixed using latest Aurora 34.0a2 build (20141008004004) under Win 7 64-bit, Ubuntu 13.04 64-bit and Mac OSX 10.9.5.
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•