Closed
Bug 1011365
Opened 11 years ago
Closed 11 years ago
[B2G][Browser]Showing the rightmost character when URL is selected
Categories
(Firefox OS Graveyard :: Gaia::Browser, defect)
Tracking
(feature-b2g:2.0)
People
(Reporter: howie, Assigned: daleharvey)
References
Details
(Whiteboard: [systemsfe])
Attachments
(2 files)
For FF OS v2.0 text selection feature, when selecting the url, it should show the rightmost character. Please refer to the spec p.10, step 2.
Reporter | ||
Comment 1•11 years ago
|
||
Hi Candice, sorry for the late notice, there's one browser related thing might need your help. Could you see if you can find someone to solve it? Thank you.
Flags: needinfo?(cserran)
Assignee | ||
Comment 2•11 years ago
|
||
Hey howie, what additional support do you need from the browser? its a plain text field and I cant see from the spec any unique functionality, but happy to help out if I can
Flags: needinfo?(cserran) → needinfo?(hochang)
Reporter | ||
Comment 3•11 years ago
|
||
Hi Dale, thank you! Do you see page 10 of the spec, when user taps on the url bar, the url selected all and scrolled to the right end? Currently, when tapping the url, it's selected all but no scrolling to the end of it; take the spec for example, in url bar now you see http://activeapplication.. instead of ...tiveapplication.net/ after tapping on it.
Flags: needinfo?(hochang)
Assignee | ||
Comment 5•11 years ago
|
||
I see what you mean now, and yeh thats exclusive to the browser app, will do, cheers
Assignee: nobody → dale
Flags: needinfo?(dale)
Assignee | ||
Comment 6•11 years ago
|
||
I filed https://t.co/su45C06SAu for why we needed to switch to setSelectionRange to do this.
Attempted to do the same with the rocketbar, but there are a few bugs in its focus functionality so will address seperately
Attachment #8428637 -
Flags: review?(bfrancis)
Comment 7•11 years ago
|
||
Comment on attachment 8428637 [details]
https://github.com/mozilla-b2g/gaia/pull/19639
This is pretty cool.
One comment on GitHub.
Attachment #8428637 -
Flags: review?(bfrancis)
Comment 8•11 years ago
|
||
Comment on attachment 8428637 [details]
https://github.com/mozilla-b2g/gaia/pull/19639
r+ with nits fixed
Attachment #8428637 -
Flags: review+
Assignee | ||
Comment 9•11 years ago
|
||
Addressed review comment and landed in: https://github.com/mozilla-b2g/gaia/commit/ea2e278ad0d93c06fb4cdb86509688c98f7b0ae5
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 10•10 years ago
|
||
cool! Thanks Dale!
Updated•10 years ago
|
Whiteboard: [systemsfe]
Reporter | ||
Updated•10 years ago
|
feature-b2g: --- → 2.0
You need to log in
before you can comment on or make changes to this bug.
Description
•