When I am working on bug 1010035 I notice this issue. Think about the case: 1) modem reports call (parentCall) disconnected [1] 2) then [2] have its childCall updated 3) now, [1] gets called again with aCall being the childCall 4) [3] tries to update childCall's property 'isActive' but something goes wrong because childCall.isConference hasn't been set to false yet that leads to unexpected result... The fix is simple, moving [3] to line#777 should be fine! [1] http://dxr.mozilla.org/mozilla-central/source/dom/telephony/gonk/TelephonyProvider.js?from=TelephonyProvider.js#735 [2] http://dxr.mozilla.org/mozilla-central/source/dom/telephony/gonk/TelephonyProvider.js?from=TelephonyProvider.js#758 [3] http://dxr.mozilla.org/mozilla-central/source/dom/telephony/gonk/TelephonyProvider.js?from=TelephonyProvider.js#751

Thank you :)

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #1) > Created attachment 8423760 [details] [diff] [review] > 1011429.patch > > Thank you :) You could verify the fix by attachment 8423779 [details] [diff] [review] [diff] [review].

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #0) > When I am working on bug 1010035 I notice this issue. > > Think about the case: > 1) modem reports call (parentCall) disconnected [1] > 2) then [2] have its childCall updated > 3) now, [1] gets called again with aCall being the childCall > 4) [3] tries to update childCall's property 'isActive' but something goes > wrong because childCall.isConference hasn't been set to false yet that leads > to unexpected result... > 5) [4] is called. And when [4] is called, parentCall.state is still CONNECTED that makes PHONE_STATE set to IN_CALL. We have no chance to set PHONE_STATE to NORMAL eventually that is another unexpected behaviour. > The fix is simple, moving [3] to line#777 should be fine! > > [1] > http://dxr.mozilla.org/mozilla-central/source/dom/telephony/gonk/ > TelephonyProvider.js?from=TelephonyProvider.js#735 > [2] > http://dxr.mozilla.org/mozilla-central/source/dom/telephony/gonk/ > TelephonyProvider.js?from=TelephonyProvider.js#758 > [3] > http://dxr.mozilla.org/mozilla-central/source/dom/telephony/gonk/ > TelephonyProvider.js?from=TelephonyProvider.js#751 [4] http://dxr.mozilla.org/mozilla-central/source/dom/telephony/gonk/TelephonyProvider.js?from=TelephonyProvider.js#773

Comment on attachment 8423760 [details] [diff] [review] 1011429.patch Review of attachment 8423760 [details] [diff] [review]: ----------------------------------------------------------------- Vicamo is taking 2-week PTO, deferring the review to Aknow. Hi Aknow, may I have your help?

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #2) > (In reply to Hsin-Yi Tsai [:hsinyi] from comment #1) > > Created attachment 8423760 [details] [diff] [review] > > 1011429.patch > > > > Thank you :) > > You could verify the fix by attachment 8423779 [details] [diff] [review] > [diff] [review]. Also apply the emulator patches: Bug 1009393 - [B2G][Emulator] support RIL_REQUEST_CDMA_FLASH

Comment on attachment 8423760 [details] [diff] [review] 1011429.patch Review of attachment 8423760 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. Thank you.

Thanks for the review! https://hg.mozilla.org/integration/b2g-inbound/rev/be01ada44904