Closed
Bug 1011504
Opened 10 years ago
Closed 9 years ago
Edit>Find in Scratchpad doesn't work
Categories
(DevTools Graveyard :: Scratchpad, defect)
Tracking
(firefox41 verified)
VERIFIED
FIXED
Firefox 41
Tracking | Status | |
---|---|---|
firefox41 | --- | verified |
People
(Reporter: rick3162, Assigned: darkowlzz)
References
Details
(Whiteboard: [bugday-20150722])
Attachments
(1 file)
(deleted),
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0 (Beta/Release)
Build ID: 20140516030204
Steps to reproduce:
In a clean Nightly 32.0a1 (or 29.0.1 stable) profile,
open Scratchpad (Shift+F4 or via the hamburger button>Developer).
Then press Edit>Find.
Actual results:
The search box doesn''t appear.
Expected results:
The search box should appear.
(on the other hand, the search box appears ok when pressing Ctrl+F instead)
Updated•10 years ago
|
Component: Untriaged → Developer Tools: Scratchpad
Comment 1•10 years ago
|
||
Confirmed in 32.0a1 (2014-05-18), win 7 x64
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 2•9 years ago
|
||
Hello,
I gave a shot at fixing this bug. Found that editMenuOverlay [1] didn't had `onCommand` for the find and findAgain commands. Added them and it worked.
Not sure whom to request for feedback/review. Some help would be great.
[1]: https://dxr.mozilla.org/mozilla-central/source/toolkit/content/editMenuOverlay.xul
Attachment #8612524 -
Flags: feedback?
Comment 3•9 years ago
|
||
Comment on attachment 8612524 [details] [diff] [review]
Added command listeners for `cmd_find` and `cmd_findAgain`.
Maybe Patrick can review this, or if not, redirect it?
Attachment #8612524 -
Flags: feedback? → review?(pbrosset)
Comment 4•9 years ago
|
||
Comment on attachment 8612524 [details] [diff] [review]
Added command listeners for `cmd_find` and `cmd_findAgain`.
Looks good, thanks!
Next time you can click on the "suggested reviewers" link next to the review field to see a list.
Attachment #8612524 -
Flags: review?(pbrosset) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Thanks Gijs and Panos.
Anything else that is left to be done here?
Comment 7•9 years ago
|
||
Nope, I made sure the tests still pass locally and landed it.
Assignee: nobody → indiasuny000
Status: NEW → ASSIGNED
Comment 8•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Comment 10•9 years ago
|
||
Reproduced the bug in Nightly 32.0a1 (2014-05-16) on Linux x64 by following comment 0's instruction!
This Bug is now verified as fixed on Latest Aurora 41.0a2 (2015-07-21)
Build ID: 20150722004007
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0
QA Whiteboard: [bugday-20150722]
Whiteboard: [bugday-20150722]
Comment 11•9 years ago
|
||
I have successfully reproduced the bug in Nightly 32.0a1(2014-05-16)(Build ID: 20140516030204)on Windows 10 x64.
Bug is now fixed on Latest Aurora 41.0a2 (2015-07-21) Build ID: 20150721004010
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:41.0) Gecko/20100101 Firefox/41.0
Comment 12•9 years ago
|
||
It is verified on Linux and Windows (Comment 10 and Comment 11), Marking it as verified!
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•