Closed Bug 1011504 Opened 10 years ago Closed 9 years ago

Edit>Find in Scratchpad doesn't work

Categories

(DevTools Graveyard :: Scratchpad, defect)

32 Branch
x86_64
Windows 8.1
defect
Not set
normal

Tracking

(firefox41 verified)

VERIFIED FIXED
Firefox 41
Tracking Status
firefox41 --- verified

People

(Reporter: rick3162, Assigned: darkowlzz)

References

Details

(Whiteboard: [bugday-20150722])

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0 (Beta/Release) Build ID: 20140516030204 Steps to reproduce: In a clean Nightly 32.0a1 (or 29.0.1 stable) profile, open Scratchpad (Shift+F4 or via the hamburger button>Developer). Then press Edit>Find. Actual results: The search box doesn''t appear. Expected results: The search box should appear. (on the other hand, the search box appears ok when pressing Ctrl+F instead)
Component: Untriaged → Developer Tools: Scratchpad
Confirmed in 32.0a1 (2014-05-18), win 7 x64
Status: UNCONFIRMED → NEW
Ever confirmed: true
Hello, I gave a shot at fixing this bug. Found that editMenuOverlay [1] didn't had `onCommand` for the find and findAgain commands. Added them and it worked. Not sure whom to request for feedback/review. Some help would be great. [1]: https://dxr.mozilla.org/mozilla-central/source/toolkit/content/editMenuOverlay.xul
Attachment #8612524 - Flags: feedback?
Comment on attachment 8612524 [details] [diff] [review] Added command listeners for `cmd_find` and `cmd_findAgain`. Maybe Patrick can review this, or if not, redirect it?
Attachment #8612524 - Flags: feedback? → review?(pbrosset)
Comment on attachment 8612524 [details] [diff] [review] Added command listeners for `cmd_find` and `cmd_findAgain`. Looks good, thanks! Next time you can click on the "suggested reviewers" link next to the review field to see a list.
Attachment #8612524 - Flags: review?(pbrosset) → review+
Thanks Gijs and Panos. Anything else that is left to be done here?
Nope, I made sure the tests still pass locally and landed it.
Assignee: nobody → indiasuny000
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Reproduced the bug in Nightly 32.0a1 (2014-05-16) on Linux x64 by following comment 0's instruction! This Bug is now verified as fixed on Latest Aurora 41.0a2 (2015-07-21) Build ID: 20150722004007 User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0
QA Whiteboard: [bugday-20150722]
Whiteboard: [bugday-20150722]
I have successfully reproduced the bug in Nightly 32.0a1(2014-05-16)(Build ID: 20140516030204)on Windows 10 x64. Bug is now fixed on Latest Aurora 41.0a2 (2015-07-21) Build ID: 20150721004010 Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:41.0) Gecko/20100101 Firefox/41.0
It is verified on Linux and Windows (Comment 10 and Comment 11), Marking it as verified!
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: