Closed
Bug 1011660
Opened 11 years ago
Closed 10 years ago
Stop having a separate DOMClass struct
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: bzbarsky, Assigned: efaust)
Details
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
With the patch in bug 1010658, the only thing holding a pointer to DOMClass is the DOMJSClass. So we should just be able to move the DOMClass fields into DOMJSClass.
Peter, any obvious reasons not to do that?
Flags: needinfo?(peterv)
|
Assignee | |
Comment 2•10 years ago
|
||
I left DOMClass in Codegen.py, since although we don't need a seperate struct, we still need to gen the same data in both proxy and non-proxy classes.
Attachment #8434665 -
Flags: review?(bzbarsky)
|
Reporter | |
Comment 3•10 years ago
|
||
Comment on attachment 8434665 [details] [diff] [review]
Remove DOMClass
>- {
> { ${protoChain} },
Does the indent end up correct in the generated code? Or do you need to outdent by 2 here?
r=me for whichever version makes the indent right.
Attachment #8434665 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
|
||
Comment 5•10 years ago
|
||
Assignee: nobody → efaustbmo
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•