Tiffanie Shakespeare [:tif] Reporter
	Description • 10 years ago

STR

1. Launch Video app
2. Select and start playing a video
3. Tap info icon (or trash, more menu icon, etc)

Expected 
Video that is playing pauses automatically when an action menu or dialogue appears

Actual
Video continues to play until the end of the video is reached

	Selvaraj
	Comment 1 • 10 years ago

I have tested on Nexus 4 .The issue is not reproducible .I could play the video while selecting info ,trash icon .
OS Version: 2.0.0.0-prerelease
Hardware Version: Mako
platform version:31.0a1
Build identifier:20140515174422

	Tiffanie Shakespeare [:tif] Reporter
	Comment 2 • 10 years ago

I think you misunderstood - the video should not be playing when while selecting those things; the video should pause when the user taps on those items.

	Selvaraj
	Comment 4 • 10 years ago

Please review

	Russ Nicoletti [:russn]
	Comment 5 • 10 years ago

Comment on attachment 8428621 [details]
github PR

The patch works well. However, I'm giving r- due to code duplication. Also, would be good to add unit tests in video_test.js for the new logic. Thanks.

	Russ Nicoletti [:russn]
	Comment 6 • 10 years ago

Please squash your commits in your branch before pushing again to github. When there is more than one commit per bug, it makes it hard to back out the changes (if ever that was necessary). Thanks!

	Tiffanie Shakespeare [:tif] Reporter
	Comment 7 • 10 years ago

Comment on attachment 8428621 [details]
github PR

Removing review flag and setting UI-review flag. 

Just FYI - review is for dev to check and comment on your code. UI-review is for designers to check out your patch and make comments from an interaction/visual design perspective.

	Tiffanie Shakespeare [:tif] Reporter
	Comment 8 • 10 years ago

Comment on attachment 8428621 [details]
github PR

Overall, the patch looks good. I did notice a couple of instances where the video would resume playing when it was actually paused beforehand. I also broke the playback once (not sure if this is because of the patch or not).

It also seems like the video resuming from a share activity is inconsistent. For example, I select Messaging where I get a "File too large" notification and when I hit ok video is still paused. While if I select Email and get a "email not setup" notification, pressing cancel returns and resumes playing.

I think a good rule of thumb would be if the user is leaving the app - e.g. selects something from the share menu, the video should pause and remain paused. If the user selects the info button or cancels the delete/share, the video should resume. 

Can we do this? Thanks so much!

	Selvaraj
	Comment 9 • 10 years ago

i have changed as per the review comments .Please review

	Tiffanie Shakespeare [:tif] Reporter
	Comment 10 • 10 years ago

Comment on attachment 8428621 [details]
github PR

Seems good. The play/pause seem to be more consistent - thanks!

	Russ Nicoletti [:russn]
	Comment 11 • 10 years ago

I've update the PR with my comments on the latest commit. 

Also, it is important to squash the commits (e.g., git rebase -i master) so that the PR contains only one commit. When you push the branch after 'squashing' the commits, use git push -f).

	BMO Automation
	Comment 12 • 6 years ago

Firefox OS is not being worked on