Closed
Bug 1011806
Opened 11 years ago
Closed 11 years ago
Stop loading user-agent/user style sheets for SVG-as-an-image (leave svg.css, html.css and xul.css loading on-demand)
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: jwatt, Assigned: jwatt)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [MemShrink:P2])
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
With the testcase from bug 999931 on the keon, skipping the loading of all UA style sheets other than svg.css reduces the image memory by 75%.
This builds on bug 1008455 and bug 1011802 (which provide wins for most document types) by being much more aggressive for SVG-as-an-image only.
Comment 1•11 years ago
|
||
When somebody new starts looking for ways to reduce memory usage in parts of the browser that haven't been looked at closely, it's great to see what they find :)
Assignee | ||
Comment 2•11 years ago
|
||
Well let's see if this flies. ;)
Assignee | ||
Comment 3•11 years ago
|
||
Assignee: nobody → jwatt
Attachment #8426356 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #8426356 -
Attachment is obsolete: true
Attachment #8426356 -
Flags: review?(bzbarsky)
Attachment #8426359 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•11 years ago
|
Summary: Preload only the svg.css user-agent style sheet for SVG-as-an-image → Stop loading user-agent/user style sheets for SVG-as-an-image (leave svg.css, html.css and xul.css loading on-demand)
Assignee | ||
Updated•11 years ago
|
Comment 5•11 years ago
|
||
Comment on attachment 8426359 [details] [diff] [review]
patch
r=me as long as you don't land this before its dependencies. ;)
Attachment #8426359 -
Flags: review?(bzbarsky) → review+
Comment 6•11 years ago
|
||
Comment on attachment 8426359 [details] [diff] [review]
patch
Actually, r- per IRC discussion since the prereqs don't do what I thought they did.
Attachment #8426359 -
Flags: review+ → review-
Assignee | ||
Comment 7•11 years ago
|
||
With the changes made to the part 2 patch in bug 1013936 I think this is okay now.
Attachment #8426359 -
Attachment is obsolete: true
Attachment #8426608 -
Flags: review?(bzbarsky)
Comment 8•11 years ago
|
||
Comment on attachment 8426608 [details] [diff] [review]
patch
r=me
Attachment #8426608 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 9•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 10•11 years ago
|
||
Updated•11 years ago
|
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•