Closed
Bug 1011810
Opened 10 years ago
Closed 10 years ago
ICCManager.getIccById is declared as returning "nsISupports" but can return null
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
smaug
:
review+
hsinyi
:
review+
|
Details | Diff | Splinter Review |
This is causing the patch in bug 1008236 to fail, of course, since it asserts that actual return types match claimed ones.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8424258 -
Flags: review?(htsai)
Attachment #8424258 -
Flags: review?(bugs)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8424276 -
Flags: review?(htsai)
Attachment #8424276 -
Flags: review?(bugs)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8424258 -
Attachment is obsolete: true
Attachment #8424258 -
Flags: review?(htsai)
Attachment #8424258 -
Flags: review?(bugs)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8424276 [details] [diff] [review]
Return the right type from getIccById
Oh, we can't return nsISupports anymore if there is some real webidl type defined?
Attachment #8424276 -
Flags: review?(bugs) → review+
|
|
||
Comment 4•10 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #3)
> Oh, we can't return nsISupports anymore if there is some real webidl type
> defined?
Or that was just an additional fix. '?' was the real fix
|
|
Assignee | |
Comment 5•10 years ago
|
||
> Or that was just an additional fix. '?' was the real fix
Precisely.
|
||
Updated•10 years ago
|
Attachment #8424276 -
Flags: review?(htsai) → review+
|
|
Assignee | |
Comment 6•10 years ago
|
||
Thanks for the reviews!
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a6216f789ea
Flags: in-testsuite+
Whiteboard: [need review]
|
||
Comment 7•10 years ago
|
||
This needs to be uplifted as well in order for me to uplift bug 1004458 since beta merges to b2g30 and B2G debug will burn otherwise.
Flags: needinfo?(bzbarsky)
|
|
Assignee | |
Comment 8•10 years ago
|
||
Bug 1004458 doesn't depend on this patch.
Flags: needinfo?(bzbarsky)
|
|
||
Comment 9•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•