Closed
Bug 1012656
Opened 10 years ago
Closed 10 years ago
[PDF.js] Remove inline style for CSP compliance
Categories
(Firefox OS Graveyard :: Gaia::PDF Viewer, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gerard-majax, Assigned: vingtetun)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
yury
:
feedback+
|
Details | Diff | Splinter Review |
Confere bug 968907 and bug 858787. We need to remove all CSS inline usage in certified apps.
https://github.com/mozilla-b2g/gaia/blob/master/apps/pdfjs/content/web/viewer.html#L86
|
Assignee | |
Comment 1•10 years ago
|
||
The app can really just be privileged. It does not need access to mozSettings as it used a web version of l10n.js that does not use mozSettings anyway, and as the new l10n.js file rely on languagechange instead of mozSettings.
Attachment #8437341 -
Flags: review?(bdahl)
|
||
Comment 3•10 years ago
|
||
(In reply to Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) from comment #1)
> Created attachment 8437341 [details] [diff] [review]
> csp.pdfjs.patch
>
> The app can really just be privileged. It does not need access to
> mozSettings as it used a web version of l10n.js that does not use
> mozSettings anyway, and as the new l10n.js file rely on languagechange
> instead of mozSettings.
Hi Vivien, bdahl is on leave until September, I recommend you ask Yury Delendik for review here.
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8437341 [details] [diff] [review]
csp.pdfjs.patch
Hi Vivien, PDF.js only needs XHR access, so I guess the changes in the attachment 8437341 [details] [diff] [review] will be fine (and there is no need to uplift to the pdf.js repo)
Attachment #8437341 -
Flags: review?(bdahl) → feedback+
Flags: needinfo?(ydelendik)
|
|
Assignee | |
Comment 6•10 years ago
|
||
Assignee: nobody → 21
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 7•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•