Closed Bug 1012677 Opened 11 years ago Closed 10 years ago

Investigate delayed initialization of nsILoginManager in Firefox for Android

Categories

(Firefox for Android Graveyard :: Data Providers, defect)

All
Android
defect
Not set
normal

Tracking

(firefox32+ fixed, firefox33 fixed, firefox34 fixed)

RESOLVED FIXED
Firefox 34
Tracking Status
firefox32 + fixed
firefox33 --- fixed
firefox34 --- fixed

People

(Reporter: Paolo, Assigned: mfinkle)

References

Details

Attachments

(1 file)

Some automated tests show that early initialization of the Login Manager service (nsILoginManager) in Firefox for Android is still required by the Java code that accesses the logins database. However, it might be possible to introduce lazy initialization like bug 856470 has done for Desktop. In fact it's not clear if this requirement is caused by the Data Providers themselves or by the Java tests that use them.
This line should be moved inside a setTimeout call: http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#402 This should not affect the browser, however it causes some Java test failures.
Blocks: 1018463
Tracking for 32 as Paolo expects that this bug will fix bug 1018463.
Assignee: nobody → mark.finkle
Attached patch change-loginmanager-delay v0.1 (deleted) — Splinter Review
I decided to use the delayed-startup system for this and not use a setTimeout. I moved the SafeBrowsing init in here too, since it was in it's owe 5 second setTimeout to avoid startup performance issues. I also queued these on the main thread to allow them to not create a large blocking call. Try run here, but we'll need to look at autophone specifically: https://tbpl.mozilla.org/?tree=Try&rev=a49f3c0ca2fa
Attachment #8465722 - Flags: review?(margaret.leibovic)
Attachment #8465722 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/integration/fx-team/rev/e21dd0c363f8 If autophone doesn't see any change, or maybe even sees a regression, I can add the setTimeout.
Comment on attachment 8465722 [details] [diff] [review] change-loginmanager-delay v0.1 Approval Request Comment [Feature/regressing bug #]:bug 1018463 [User impact if declined]: Performance regression [Describe test coverage new/current, TBPL]:Just landed and we need to wait for an autophone test run [Risks and why]: Low, just mocving code to a different place in startup. [String/UUID change made/needed]: none
Attachment #8465722 - Flags: approval-mozilla-beta?
Attachment #8465722 - Flags: approval-mozilla-aurora?
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Attachment #8465722 - Flags: approval-mozilla-beta?
Attachment #8465722 - Flags: approval-mozilla-beta+
Attachment #8465722 - Flags: approval-mozilla-aurora?
Attachment #8465722 - Flags: approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: