Closed
Bug 1012735
Opened 11 years ago
Closed 10 years ago
Use HeapCopyOfStackArray for the fBufferData call in nsChildView.mm
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: mstange, Assigned: mstange)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bjacob
:
review+
|
Details | Diff | Splinter Review |
This is the buffering of the quad that we use with BasicCompositor on Mac to present the basic composition result to the screen.
Attachment #8424914 -
Flags: review?(bjacob)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8424914 [details] [diff] [review]
v1
Review of attachment 8424914 [details] [diff] [review]:
-----------------------------------------------------------------
::: widget/cocoa/nsChildView.mm
@@ +2912,5 @@
> + verticesOnHeap.ByteLength(),
> + verticesOnHeap.Data(),
> + LOCAL_GL_STATIC_DRAW);
> + mGLContext->fBindBuffer(LOCAL_GL_ARRAY_BUFFER, 0);
> +
Extra line of whitespace here.
Attachment #8424914 -
Flags: review?(bjacob) → review+
|
||
Comment 2•11 years ago
|
||
checkin-needed?
|
Assignee | |
Comment 3•11 years ago
|
||
oops! checkin-incoming.
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
|
Assignee | |
Comment 5•11 years ago
|
||
and https://hg.mozilla.org/integration/mozilla-inbound/rev/9db1e2f6d026 for the whitespace fix (addresses comment 1)
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7a812cce3895
https://hg.mozilla.org/mozilla-central/rev/9db1e2f6d026
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•