Closed
Bug 1012748
Opened 11 years ago
Closed 11 years ago
remove nsIXPCSecurityManager
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(3 files)
(deleted),
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
Bobby indicated in bug 996061 that this interface should just be removed.
Removing it also makes parts of that bug easier, so let's go ahead and do that.
Assignee | ||
Comment 1•11 years ago
|
||
Getting rid of unused fields is a good starting point.
Attachment #8424934 -
Flags: review?(bobbyholley)
Assignee | ||
Comment 2•11 years ago
|
||
Another minor cleanup before we get to the real patch.
Attachment #8424935 -
Flags: review?(bobbyholley)
Assignee | ||
Comment 3•11 years ago
|
||
Finally, the removal. Nothing complicated here.
Attachment #8424943 -
Flags: review?(bobbyholley)
Comment 4•11 years ago
|
||
Comment on attachment 8424934 [details] [diff] [review]
part 1 - remove unused mDefaultSecurityManager field
Review of attachment 8424934 [details] [diff] [review]:
-----------------------------------------------------------------
Good catch. I thought I removed this.
Attachment #8424934 -
Flags: review?(bobbyholley) → review+
Updated•11 years ago
|
Attachment #8424935 -
Flags: review?(bobbyholley) → review+
Comment 5•11 years ago
|
||
Comment on attachment 8424943 [details] [diff] [review]
part 3 - remove nsIXPCSecurityManager
Review of attachment 8424943 [details] [diff] [review]:
-----------------------------------------------------------------
\o/
Attachment #8424943 -
Flags: review?(bobbyholley) → review+
Comment 6•11 years ago
|
||
Comment on attachment 8424943 [details] [diff] [review]
part 3 - remove nsIXPCSecurityManager
Review of attachment 8424943 [details] [diff] [review]:
-----------------------------------------------------------------
::: caps/idl/nsIScriptSecurityManager.idl
@@ +15,5 @@
> +#include "jspubtd.h"
> +%}
> +
> +[ptr] native JSContextPtr(JSContext);
> +[ptr] native JSObjectPtr(JSObject);
I don't think you need this.
Assignee | ||
Comment 7•11 years ago
|
||
(In reply to Tom Schuster [:evilpie] from comment #6)
> Comment on attachment 8424943 [details] [diff] [review]
> part 3 - remove nsIXPCSecurityManager
>
> Review of attachment 8424943 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: caps/idl/nsIScriptSecurityManager.idl
> @@ +15,5 @@
> > +#include "jspubtd.h"
> > +%}
> > +
> > +[ptr] native JSContextPtr(JSContext);
> > +[ptr] native JSObjectPtr(JSObject);
>
> I don't think you need this.
You do, since the newly-added can* methods for that interface take native pointer types. Without those, you get:
Traceback (most recent call last):
File "/home/froydnj/src/gecko-dev.git/config/pythonpath.py", line 56, in <module>
main(sys.argv[1:])
File "/home/froydnj/src/gecko-dev.git/config/pythonpath.py", line 48, in main
execfile(script, frozenglobals)
File "/home/froydnj/src/gecko-dev.git/python/mozbuild/mozbuild/action/xpidl-process.py", line 92, in <module>
main(sys.argv[1:])
File "/home/froydnj/src/gecko-dev.git/python/mozbuild/mozbuild/action/xpidl-process.py", line 89, in main
args.xptdir, args.depsdir, args.module, args.idls)
File "/home/froydnj/src/gecko-dev.git/python/mozbuild/mozbuild/action/xpidl-process.py", line 43, in process
idl.resolve([input_dir] + inc_paths, p)
File "/home/froydnj/src/gecko-dev.git/xpcom/idl-parser/xpidl.py", line 287, in resolve
p.resolve(self)
File "/home/froydnj/src/gecko-dev.git/xpcom/idl-parser/xpidl.py", line 516, in resolve
member.resolve(self)
File "/home/froydnj/src/gecko-dev.git/xpcom/idl-parser/xpidl.py", line 834, in resolve
p.resolve(self)
File "/home/froydnj/src/gecko-dev.git/xpcom/idl-parser/xpidl.py", line 944, in resolve
self.realtype = method.iface.idl.getName(self.type, self.location)
File "/home/froydnj/src/gecko-dev.git/xpcom/idl-parser/xpidl.py", line 271, in getName
raise IDLError("type '%s' not found" % id, location)
xpidl.IDLError: error: type 'JSContextPtr' not found, ../../../dist/idl/nsIScriptSecurityManager.idl line 28:40
[noscript] void canCreateWrapper(in JSContextPtr aJSContext,
Comment 8•11 years ago
|
||
>error: type 'JSContextPtr' not found
Seems like you removed JSContextPtr and not JSObjectPtr.
Assignee | ||
Comment 9•11 years ago
|
||
(In reply to Tom Schuster [:evilpie] from comment #8)
> >error: type 'JSContextPtr' not found
>
> Seems like you removed JSContextPtr and not JSObjectPtr.
Ah, my mistake, I misread and thought you were saying that all of those could be removed. I think you're correct, and will remove those before landing.
Assignee | ||
Comment 10•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/846c9c999657
https://hg.mozilla.org/integration/mozilla-inbound/rev/561a17f55e0c
https://hg.mozilla.org/integration/mozilla-inbound/rev/913c11930bdb
Flags: in-testsuite-
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → nfroyd
Comment 11•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/846c9c999657
https://hg.mozilla.org/mozilla-central/rev/561a17f55e0c
https://hg.mozilla.org/mozilla-central/rev/913c11930bdb
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•