Closed
Bug 1013085
Opened 10 years ago
Closed 10 years ago
change gaia-header folder name
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(b2g-v2.0 fixed)
RESOLVED
FIXED
2.0 S2 (23may)
Tracking | Status | |
---|---|---|
b2g-v2.0 | --- | fixed |
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
(Whiteboard: [p=1],[systemsfe])
Attachments
(1 file)
Before we have too many implementations, I would like to quickly rename the custom elements to match our platform standards. This will likely cause some conflicts with your branchs, and I apologize for that, but it is important that we adhere to our file patterns. We are supposed to be using underscores for file names and folders: https://developer.mozilla.org/en-US/Firefox_OS/Platform/Gaia/Hacking#Coding_style_basics
Assignee | ||
Comment 1•10 years ago
|
||
Yan, Wilson - could you guys give this a review stamp when you have the time? Thanks! Apologies for not having a linter about this. It is a bit weird to have a syntax standard without a linter, so hopefully we'll get one soon.
Attachment #8425274 -
Flags: review?(yor)
Attachment #8425274 -
Flags: review?(wilsonpage)
Assignee | ||
Updated•10 years ago
|
Whiteboard: [p=2],[systemsfe] → [p=1],[systemsfe]
Target Milestone: --- → 2.0 S2 (23may)
Comment 2•10 years ago
|
||
Comment on attachment 8425274 [details]
Github pull request
Urgh, underscores are so gross, especially as dashes match our element names. But I guess I'm too late to the game to argue this.
<gaia_header>:'(</gaia_header>
Attachment #8425274 -
Flags: review?(wilsonpage) → review+
Assignee | ||
Comment 3•10 years ago
|
||
I understand - and I am going to miss the fact that it doesn't match our elements exactly, but I guess this is also the problem with *every* JS class we currently have. Thanks for the review, and sorry we have to make the change for consistency.
Comment on attachment 8425274 [details]
Github pull request
Works for me.
Attachment #8425274 -
Flags: review?(yor) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Thanks guys. Again - hopefully I didn't cause too many rebase problems. Beers on me if I did. Landed: https://github.com/mozilla-b2g/gaia/commit/1609e724e10ca78b9f1523b94a7862fdbed496be
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
status-b2g-v2.0:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•