Closed
Bug 1013475
Opened 11 years ago
Closed 11 years ago
make inIDeepTreeWalker stop depending on nsIDOMTreeWalker
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
nsIDOMTreeWalker isn't scriptable, and inIDeepTreeWalker is. We shouldn't have such interfaces in our tree.
|
Assignee | |
Comment 1•11 years ago
|
||
Cut-and-paste programming at its finest.
Attachment #8425650 -
Flags: review?(bzbarsky)
|
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8425650 [details] [diff] [review]
give inIDeepTreeWalker all of nsIDOMTreeWalker's methods/attributes, rather than inheriting them
r=me assuming nothing on the C++ side tries to use this sucker as an nsIDOMTreeWalker.
Attachment #8425650 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Try run said no C++ use:
https://tbpl.mozilla.org/?tree=Try&rev=ae069f151f82
Then again, it's only used in this one testcase. Maybe we should just ditch the interface entirely? Do addons use it?
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea0448aacaa3
Flags: in-testsuite-
|
|
||
Comment 4•11 years ago
|
||
Hrm. The DOM inspector addon certainly does, no?
https://mxr.mozilla.org/addons/search?string=deep-tree-walker says so do another 10 addons or so.
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•