The shader editor doesn't invert the eye icons in light themes. While the style editor wrongly inverts the eye icon in the selected split view.

Would you like to take this ? I don't feel like fixing this bug. :p

Sure, I'll fix this

screenshot with and without patch applied

Comment on attachment 8425783 [details] [diff] [review] eyeballs.patch Review of attachment 8425783 [details] [diff] [review]: ----------------------------------------------------------------- OK!

Hi, I was able to reproduce it on Win7 x86_64 with 32.0a1 2014-05-20, and I can confirm the fix on latest Nightly (2014-05-27) on the same platform for both the Shader and Style Editor with a light theme. I tried to verify it also on Linux x86_64 and the Style Editor icon with light theme is ok in latest Nightly, but I found out that both in 32.0a1 (2014-05-21) and latest Nightly (2014-05-27) there is no eyeball icon for Shader Editor but a checked box (see screenshot attached). Is this done on purpose? And if not, should I file another bug? To test the Shader Editor I used this page → https://www.khronos.org/registry/webgl/sdk/demos/google/san-angeles/index.html Cheers, Francesca

(In reply to Francesca Ciceri [:madamezou] from comment #9) > Created attachment 8429971 [details] > Shader Editor icon on Linux is a checked box > > Hi, > > I was able to reproduce it on Win7 x86_64 with 32.0a1 2014-05-20, and I can > confirm the fix on latest Nightly (2014-05-27) on the same platform for both > the Shader and Style Editor with a light theme. > > > I tried to verify it also on Linux x86_64 and the Style Editor icon with > light theme is ok in latest Nightly, but I found out that both in 32.0a1 > (2014-05-21) and latest Nightly (2014-05-27) there is no eyeball icon for > Shader Editor but a checked box (see screenshot attached). Is this done on > purpose? And if not, should I file another bug? > > To test the Shader Editor I used this page → > https://www.khronos.org/registry/webgl/sdk/demos/google/san-angeles/index. > html > > Cheers, > Francesca This seems like a new Linux specific bug.

> > I tried to verify it also on Linux x86_64 and the Style Editor icon with > > light theme is ok in latest Nightly, but I found out that both in 32.0a1 > > (2014-05-21) and latest Nightly (2014-05-27) there is no eyeball icon for > > Shader Editor but a checked box (see screenshot attached). Is this done on > > purpose? And if not, should I file another bug? Francesca, thanks for looking into this. Two questions: 1) Is this checkbox issue on Linux also a problem in the Style Editor? 2) Can you please check on Aurora 31 to see if there is an eyeball icon there for the Shader Editor?

Hi Brian, I've filed Bug 1016998 for this issue (and I've taken the liberty of cc-ing you there). I already replied to your questions on the other bug, but for the sake of completeness I'll do it here as well :). (In reply to Brian Grinstead [:bgrins] from comment #11) > Francesca, thanks for looking into this. Two questions: > > 1) Is this checkbox issue on Linux also a problem in the Style Editor? No, Style Editor is fine on all the versions (latest Nightly, Aurora and Beta in both dark and light theme) > 2) Can you please check on Aurora 31 to see if there is an eyeball icon > there for the Shader Editor? Yes: Aurora is affected as well. And Beta. Cheers, Francesca

Also verified on Mac OS X 10.9.4 using latest Firefox 32 Beta 1 build, and everything looks fine for both the Style and the Shader Editor. Since this was also verified on Windows and the Linux issue is tracked separately, I'm marking this as verified.