Open Bug 1013645 Opened 10 years ago Updated 2 years ago

Investigate using global mode in irregexp

Categories

(Core :: JavaScript Engine: JIT, defect)

x86
macOS
defect

Tracking

()

People

(Reporter: bhackett1024, Unassigned)

References

Details

Attachments

(1 file)

Attached patch patch (f06a7deabcb9) (deleted) — Splinter Review
Irregexp supports allowing jitcode to find all matches for a given regexp in an input string, instead of just the first match. This is currently inactive in the irregexp port, and is enabled by the attached patch. This is a nice improvement for global regexp execution. If I repeatedly run the /\d+/g regexp times on an 8kb string with a mix of digits and characters then using global mode is 20%-40% faster than repeatedly finding single matches. Unfortunately though this doesn't really impact benchmark scores. So maybe it's a good idea to land this (otherwise we should remove the global stuff entirely) but I think this can wait until yarr is entirely gone, which will simplify the code a lot.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: