in-content preferences, content pane: please add some space between the default font select box and the 'size' label, see screenshot.

Hi I would like to work on this. Could you please provide the link of the files on which I am supposed to work ??

I've added a new css class 'inner-groupbox-label' specific for the label in the content pane. What about this?

Comment on attachment 8581890 [details] [diff] [review] bug1013695.patch Review of attachment 8581890 [details] [diff] [review]: ----------------------------------------------------------------- This is a good start :) ::: browser/components/preferences/in-content/content.xul @@ +89,5 @@ > <caption><label>&fontsAndColors.label;</label></caption> > <hbox align="center"> > <label control="defaultFont" accesskey="&defaultFont.accesskey;">&defaultFont.label;</label> > <menulist id="defaultFont" flex="1"/> > + <label class="inner-groupbox-label" control="defaultFontSize" accesskey="&defaultSize.accesskey;">&defaultSize.label;</label> Let's use id="defaultFontSizeLabel" instead of class="inner-groupbox-label" because I think inner-groupbox-label may be too generic-sounding for how it is being used. ::: browser/themes/shared/incontentprefs/preferences.inc.css @@ +151,5 @@ > margin-right: 4px !important; > } > > +.inner-groupbox-label { > + margin-left: 4px !important; Instead of using margin-left, we have a special property name that will flip for right-to-left text. For this we should use `-moz-margin-start: 4px;`. Also, is !important necessary here?

> Also, is !important necessary here? !important is needed to override 'xul|groupbox xul|label' !important rule in http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/shared/in-content/common.inc.css#78 Maybe I could add a comment to make it more clear?

(In reply to Tiziana Sellitto [:tiziana] from comment #4) > > Also, is !important necessary here? > > !important is needed to override 'xul|groupbox xul|label' !important rule in > http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/shared/in- > content/common.inc.css#78 > Maybe I could add a comment to make it more clear? Yeah, a comment here is a good idea :)

Comment on attachment 8581951 [details] [diff] [review] Add css id selector 'defaultFontSizeLabel' in incontentprefs. Review of attachment 8581951 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks!

Verified fixed on Windows 7 64bit, Mac OSX 10.9.5 and Ubuntu 12.04 32bit using latest Aurora 39.0a2 (buildID: 20150401004004).