in-content preferences: advanced pane. Please see the attached screenshot for the alignment issue.

Add margin to align.

In this patch you add a 16px left margin. In the patch for bug 1013709 you add a 10px left padding. Why the difference? Can these be shared somehow?

The two elements in #setDefaultPane (the other bug), #setDefaultButton and description have a left-margin and #useCacheBefore from this bug not. This makes the difference. Something like: #setDefaultPane, #useCacheBefore { -moz-margin-start: 10px; /* align with checkbox-label above */ } #setDefaultPane > description, #setDefaultPane > #setDefaultButton { -moz-margin-start: 0; } would work. Would you prefer this?

This patch gives the indent class a indent of 39px and aligns also the checkboxes correctly. With changing the defaultLabel from description to label the margin is automatically 0px. This patch fixes also bug 1013709.

Comment on attachment 8427290 [details] [diff] [review] alignIndent.patch Review of attachment 8427290 [details] [diff] [review]: ----------------------------------------------------------------- This is really close. I verified the 39px amount on Windows. Did you check that this was the right size for other platforms too or do you need me to do that? ::: browser/themes/shared/incontentprefs/preferences.css @@ +912,5 @@ > +} > + > +.indent .indent checkbox, > +.indent .indent > *:first-child:not(.indent) { > + -moz-margin-start: -4px !important; *:first-child:not(.indent) is really expensive and isn't necessary here if you move class="indent" from the <hbox> down to the <button> and <label>

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #5) > Comment on attachment 8427290 [details] [diff] [review] > alignIndent.patch > > Review of attachment 8427290 [details] [diff] [review]: > ----------------------------------------------------------------- > > This is really close. I verified the 39px amount on Windows. Did you check > that this was the right size for other platforms too or do you need me to do > that? Good point, I was to optimistic all platforms where equal here. But now they are. ;) The indent is now 33px on all platforms. > ::: browser/themes/shared/incontentprefs/preferences.css > @@ +912,5 @@ > > +} > > + > > +.indent .indent checkbox, > > +.indent .indent > *:first-child:not(.indent) { > > + -moz-margin-start: -4px !important; > > *:first-child:not(.indent) is really expensive and isn't necessary here if > you move class="indent" from the <hbox> down to the <button> and <label> This is now no more needed.

Comment on attachment 8430365 [details] [diff] [review] alignIndent.patch Review of attachment 8430365 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/themes/osx/preferences/in-content/preferences.css @@ +19,5 @@ > -moz-margin-start: 0; > } > > +.checkbox-icon { > + margin-right: 0; This and... @@ +23,5 @@ > + margin-right: 0; > +} > + > +.radio-icon { > + -moz-margin-end: 0; this are maybe looking weird but I used the same properties as in toolkit are used.

Comment on attachment 8430365 [details] [diff] [review] alignIndent.patch Review of attachment 8430365 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks.

Verified fixed on Mac OSX 10.8.5 using latest Nightly 32.0a1 (buildID: 20140609030202).