Closed
Bug 1013719
Opened 10 years ago
Closed 10 years ago
in-content preferences: advanced pane, certificates: show all buttons in a single row
Categories
(Firefox :: Settings UI, defect)
Tracking
()
VERIFIED
FIXED
Firefox 32
People
(Reporter: soeren.hentzschel, Assigned: Paenglab)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
MattN
:
review+
|
Details | Diff | Splinter Review |
preferences-advanced-10.png
in-content preferences: advanced pane, certificates: please show all buttons in a single row, there is no need for two rows. See the attached screenshot.
|
Assignee | |
Comment 1•10 years ago
|
||
I don't know why this move on the second line for only OS X was made. The dialog preferences don't have it.
Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #8427104 -
Flags: review?(jaws)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8427104 [details] [diff] [review]
oneLine.patch
Review of attachment 8427104 [details] [diff] [review]:
-----------------------------------------------------------------
This came from the dialog but was removed (I think in the back by bsmith to remove the fourth button that was there). IIRC it was just so that it didn't clip on OS X which isn't a problem in-content.
Attachment #8427104 -
Flags: review?(jaws) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Keywords: checkin-needed
|
||
Comment 4•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
||
Comment 5•10 years ago
|
||
This landed with r=jaws but should have had r=MattN. Not worth it to back out, since the history is in this bug, but for future reference the patch should be updated if the reviewer changes. The way that I usually approach this is by not adding the reviewer bits to the patch summary until I have r+.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
|
||
Comment 7•10 years ago
|
||
Verified fixed on Mac OSX 10.8.5 using latest Nightly (buildID: 20140525030203). The buttons from Advanced pane, certificates are now displayed in a single row.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•