Peter Van der Beken [:peterv] Assignee
	Description • 10 years ago

apps/settings/js/hotspot.js uses openDialog, which it's expecting to get from apps/settings/js/utils.js. The test at apps/settings/test/unit/hotspot_test.js doesn't actually include that utils.js file, so it ends up using window.openDialog. As part of the switch to WebIDL for Window we're trying to make window.openDialog chrome-only but then the test starts failing because openDialog is undefined. Including that utils.js file fixes it and is probably what was intended in the first place.

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
	Comment 2 • 10 years ago

Comment on attachment 8426079 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19464

Looks good to me, but let's make sure the people that actually works on the app knows about it.

	Arthur Chen [:arthurcc][inactive after 6/30]
	Comment 3 • 10 years ago

Comment on attachment 8426079 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19464

r=me, thanks!

	Arthur Chen [:arthurcc][inactive after 6/30]
	Comment 4 • 10 years ago

master: 1b5ea790c10f3ae4fc1c08f04df8c59777b3ef73

	Julien Wajsberg [:julienw]
	Comment 5 • 10 years ago

This is the issue happening on Travis v1.3t now, because the v1.3t branch uses aurora (we need to use another branch, but we don't have firefox for v1.3t...).

I'm gonna uplift this to various branches because this is what was intended in the first place.

	Julien Wajsberg [:julienw]
	Comment 6 • 10 years ago

v1.4: e027f8be7cb9f7760337011296511cf9d5698e27
v1.3: 20cce4e5dd3ca7dfffc82ce1dce71741dd446952

v1.3t should get merged automatically later on but since I want a green Travis I'm gonna cherry-pick there too:
v1.3t: 5611a68f5c039f62ae74b828feff1530ab066d3a