Peter Van der Beken [:peterv] Assignee
	Description • 10 years ago

A number of Gaia unit tests use Sinon.JS to stub properties on |window|. Sinon.JS adds those stubs as own properties on |window|, even though some of them might live on an object in the prototype chain. We also use Mocha to detect leaking properties on the global by comparing the list of properties at various points during the tests. As we're switching Window to WebIDL the properties from EventTarget.prototype (addEventListener/removeEventListener/dispatchEvent) will not be own properties of |window|, and so Mocha will see them show up on the global as soon as we stub them using Sinon.JS. I've fixed the tests that are affected by adding these properties to the list of properties to ignore with mocha.globals(...).

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
	Comment 2 • 10 years ago

Comment on attachment 8426087 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19466

Let's ask the review to people that knows the test framework much better than me :)

	Julien Wajsberg [:julienw]
	Comment 3 • 10 years ago

Comment on attachment 8426087 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19466

Vivien, is it good enough for you if I feedback+ ? :)

I don't know much of these tests (except notifications_test), would it make sense to ask someone else (for example etienne)?

I tried to find another way of doing this but I couldn't. Maybe sinon should clean up in a better way; I'll dig in their code to see what they're really doing, but for now it looks good enough.

	Julien Wajsberg [:julienw]
	Comment 4 • 10 years ago

Actually, we're removing the global leak check in master in bug 1014180

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
	Comment 6 • 10 years ago

Comment on attachment 8426087 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19466

Seems like my review is not needed anymore!