Closed
Bug 1013998
Opened 10 years ago
Closed 10 years ago
App icon cannot be seen easily against a bright background
Categories
(DevTools Graveyard :: WebIDE, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sole, Assigned: paul)
References
Details
Attachments
(6 files, 2 obsolete files)
Seems like Gaia renders the app icons with a bit of shadow so they stand up from the background even when it's bright too. But the AppManager doesn't, so it's hard to see in this case.
Reporter | ||
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 2•10 years ago
|
||
What should we do about that? Quite annoying.
Assignee | ||
Comment 3•10 years ago
|
||
Should we change the icons use by the templates?
Flags: needinfo?(sole)
Reporter | ||
Comment 4•10 years ago
|
||
Can't we render a shadow like Gaia do? That would make any icon "white background proof".
Flags: needinfo?(sole)
Assignee | ||
Comment 5•10 years ago
|
||
I tried shadows. In many ways. But:
1) it's hard to build a shadow that works for any icon shape
2) it's hard to figure out the right color of the shadow
Basically, it's very hard to build a shadow that would work for any icon.
We will have to create better icons. I'll give it a try.
Assignee | ||
Comment 6•10 years ago
|
||
Assignee: nobody → paul
Status: NEW → ASSIGNED
Assignee | ||
Comment 7•10 years ago
|
||
Assignee | ||
Comment 8•10 years ago
|
||
These icons follow the style of normal gaia apps (here, I use the standard white background).
It's not perfect, there's still a lack of contrast with the mac toolbar.
I was thinking about using a much brighter color.
Assignee | ||
Comment 9•10 years ago
|
||
Assignee | ||
Comment 10•10 years ago
|
||
Assignee | ||
Comment 11•10 years ago
|
||
Using the standard orange we find in some gaia icons (like the Email app). I think this is better.
Assignee | ||
Comment 12•10 years ago
|
||
Assignee | ||
Comment 13•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8446549 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Attachment #8446550 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Attachment #8446560 -
Flags: review?(sole)
Assignee | ||
Updated•10 years ago
|
Attachment #8446561 -
Flags: review?(sole)
Reporter | ||
Comment 14•10 years ago
|
||
Ohh that's a neat idea. And it would match the style of Gaia too. Brilliant!
Do you have the hex gradient colours, or even better, the gradient as an SVG? I would like to apply these changes to the original SVG files and then re-render the PNGs.
These SVG are included with each app, e.g.: https://github.com/mozilla/mortar-privileged-remote-app/blob/master/img/icons/icon.svg
Assignee | ||
Comment 15•10 years ago
|
||
(In reply to Soledad Penades [:sole] [:spenades] from comment #14)
> Ohh that's a neat idea. And it would match the style of Gaia too. Brilliant!
>
> Do you have the hex gradient colours, or even better, the gradient as an
> SVG? I would like to apply these changes to the original SVG files and then
> re-render the PNGs.
I don't. I just picked the color from https://raw.githubusercontent.com/mozilla-b2g/gaia/master/apps/email/style/icons/email_126.png
Reporter | ||
Comment 16•10 years ago
|
||
OK let me see if I can find the sources or I will just update the SVGs and regenerate them.
Reporter | ||
Comment 17•10 years ago
|
||
I pinged Patryk and etc and I got some gradients we can use. I updated the two apps:
https://github.com/mozilla/mortar-privileged-remote-app/commit/67dd9b8aa45f8db8be5e111ef15c3a6ae7016d63
https://github.com/mozilla/mortar-privileged-empty-app/commit/7c6ceb27492bba545d3b109419244fa49d22aac7
They definitely can be seen now in WebIDE!
Reporter | ||
Comment 18•10 years ago
|
||
Comment on attachment 8446560 [details]
privileged-empty-app.png (orange)
trying to clear these r? flags :P
Attachment #8446560 -
Flags: review?(sole) → review-
Reporter | ||
Comment 19•10 years ago
|
||
Comment on attachment 8446561 [details]
privileged-remote-app.png (orange)
r-'ing since we got colours from UX
Attachment #8446561 -
Flags: review?(sole) → review-
Assignee | ||
Comment 20•10 years ago
|
||
Looks good to me. Can you propagate the changes to http://code.cdn.mozilla.net/templates/list.json too?
Assignee | ||
Comment 21•10 years ago
|
||
I see the new icon in the zip, but the old icon in the json.
Reporter | ||
Comment 22•10 years ago
|
||
Me too. If I download it from the admin side of S3 I do get the updated version so I don't understand what is going on-the HTTP headers say that it was last modified 18 Jun which is not the case. Let me ping the person in charge of the CDN :)
Assignee | ||
Comment 23•10 years ago
|
||
Any update?
Assignee | ||
Comment 24•10 years ago
|
||
Appears to be fixed for me. Should we close this bug?
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(sole)
Assignee | ||
Comment 25•10 years ago
|
||
Sole?
Assignee | ||
Comment 26•10 years ago
|
||
I consider this bug fixed.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•