Closed Bug 1013998 Opened 10 years ago Closed 10 years ago

App icon cannot be seen easily against a bright background

Categories

(DevTools Graveyard :: WebIDE, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sole, Assigned: paul)

References

Details

Attachments

(6 files, 2 obsolete files)

Seems like Gaia renders the app icons with a bit of shadow so they stand up from the background even when it's bright too. But the AppManager doesn't, so it's hard to see in this case.
Attached image screenshot demonstrating issue (deleted) —
Blocks: build-am2
Blocks: enable-webide
No longer blocks: build-am2
What should we do about that? Quite annoying.
Should we change the icons use by the templates?
Flags: needinfo?(sole)
Can't we render a shadow like Gaia do? That would make any icon "white background proof".
Flags: needinfo?(sole)
I tried shadows. In many ways. But: 1) it's hard to build a shadow that works for any icon shape 2) it's hard to figure out the right color of the shadow Basically, it's very hard to build a shadow that would work for any icon. We will have to create better icons. I'll give it a try.
Attached image privileged-empty-app.png (deleted) —
Assignee: nobody → paul
Status: NEW → ASSIGNED
Attached image privileged-remote-app.png (deleted) —
These icons follow the style of normal gaia apps (here, I use the standard white background). It's not perfect, there's still a lack of contrast with the mac toolbar. I was thinking about using a much brighter color.
Attached image privileged-empty-app.png (orange) (obsolete) (deleted) —
Attached image privileged-remote-app.png (orange) (obsolete) (deleted) —
Using the standard orange we find in some gaia icons (like the Email app). I think this is better.
Attached image privileged-empty-app.png (orange) (deleted) —
Attached image privileged-remote-app.png (orange) (deleted) —
Attachment #8446549 - Attachment is obsolete: true
Attachment #8446550 - Attachment is obsolete: true
Attachment #8446560 - Flags: review?(sole)
Attachment #8446561 - Flags: review?(sole)
Ohh that's a neat idea. And it would match the style of Gaia too. Brilliant! Do you have the hex gradient colours, or even better, the gradient as an SVG? I would like to apply these changes to the original SVG files and then re-render the PNGs. These SVG are included with each app, e.g.: https://github.com/mozilla/mortar-privileged-remote-app/blob/master/img/icons/icon.svg
(In reply to Soledad Penades [:sole] [:spenades] from comment #14) > Ohh that's a neat idea. And it would match the style of Gaia too. Brilliant! > > Do you have the hex gradient colours, or even better, the gradient as an > SVG? I would like to apply these changes to the original SVG files and then > re-render the PNGs. I don't. I just picked the color from https://raw.githubusercontent.com/mozilla-b2g/gaia/master/apps/email/style/icons/email_126.png
OK let me see if I can find the sources or I will just update the SVGs and regenerate them.
Attached image New icon in place (deleted) —
Comment on attachment 8446560 [details] privileged-empty-app.png (orange) trying to clear these r? flags :P
Attachment #8446560 - Flags: review?(sole) → review-
Comment on attachment 8446561 [details] privileged-remote-app.png (orange) r-'ing since we got colours from UX
Attachment #8446561 - Flags: review?(sole) → review-
Looks good to me. Can you propagate the changes to http://code.cdn.mozilla.net/templates/list.json too?
I see the new icon in the zip, but the old icon in the json.
Me too. If I download it from the admin side of S3 I do get the updated version so I don't understand what is going on-the HTTP headers say that it was last modified 18 Jun which is not the case. Let me ping the person in charge of the CDN :)
Any update?
Appears to be fixed for me. Should we close this bug?
Flags: needinfo?(sole)
Sole?
I consider this bug fixed.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Me too!
Flags: needinfo?(sole)
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: