Closed Bug 1014046 Opened 10 years ago Closed 10 years ago

Project Editor: Re-enable tests on Windows

Categories

(DevTools Graveyard :: WebIDE, defect)

All
Windows 8
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 33

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

Attachments

(1 file)

There were some failures on Windows 8 opt after landing, so tests were disabled: https://bugzilla.mozilla.org/show_bug.cgi?id=987089#c85
I've got a patch here that seems to be doing fine on windows 8 opt. I'm not 100% sure that the sync file writing is what resolved it - but it seems like a reasonable thing to do just to make sure that everything is in the right state during tests. Try push: https://tbpl.mozilla.org/?tree=Try&rev=f5a7e06ab0da
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Comment on attachment 8443799 [details] [diff] [review] projecteditor-windows-tests.patch This reenables tests on all windows platforms
Attachment #8443799 - Flags: review?(fayearthur)
Blocks: 1014237
Attachment #8443799 - Flags: review?(fayearthur) → review+
Keywords: checkin-needed
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: