Closed
Bug 1014521
Opened 10 years ago
Closed 10 years ago
Add edit mode behavior to gaia-header
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(b2g-v2.0 fixed)
RESOLVED
FIXED
2.0 S2 (23may)
Tracking | Status | |
---|---|---|
b2g-v2.0 | --- | fixed |
People
(Reporter: arnau, Assigned: arnau)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → arnau
Blocks: gaia-header
Comment 1•10 years ago
|
||
As discussed with Arnau I'd favour lower level configuration than edit-mode="true|false". It seems the functionality missing is the ability for the header to slide in/out when entering/leaving edit-mode. In the Call Log the edit-mode header is a second header that is slid out of view by default. Upon entering edit-mode the header slides in to cover the primary header. The edit mode header looks something like: <gaia-header action="cancel"></gaia-header> With an added "show|hide" and "transition" configration, we give app developers everything they need to build their own 'edit-mode' header. NEW ATTRIBUTES <gaia-header action="cancel" transiton="slide" hide></gaia-header> NEW PUBLIC API header.show(); header.hide(); header.toggle(); I'm always in favour of lower-level more primitive configuration as it takes the burden off the component authors and increases flexibily/application, and therefore likelihood of being used. From the app developer perspective I have seen developers not wanting to implement building blocks when/if they take away to much control. Let's make sure we don't do that :)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8427068 -
Flags: review?(wilsonpage)
Attachment #8427068 -
Flags: feedback?(yor)
Comment 3•10 years ago
|
||
Comment on attachment 8427068 [details]
patch in github
Looks grand lad! Few nit-picks in Github, nothing major.
Rock on! :)
Attachment #8427068 -
Flags: review?(wilsonpage) → review+
I'll defer to Wilson on the CSS. Can you drop the "data-" prefix on the new show/hide and transition attributes?
Attachment #8427068 -
Flags: feedback?(yor)
Assignee | ||
Comment 5•10 years ago
|
||
Merged: dadeed36538bf420612ece7619f8a423df1f7e02
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
status-b2g-v2.0:
--- → fixed
Target Milestone: --- → 2.0 S2 (23may)
You need to log in
before you can comment on or make changes to this bug.
Description
•