Arnau March [:arnau] ( not working in Firefox OS anymore :( ) Assignee
	Description • 10 years ago

      No description provided.

	Wilson Page [:wilsonpage]
	Comment 1 • 10 years ago

As discussed with Arnau I'd favour lower level configuration than edit-mode="true|false". It seems the functionality missing is the ability for the header to slide in/out when entering/leaving edit-mode.

In the Call Log the edit-mode header is a second header that is slid out of view by default. Upon entering edit-mode the header slides in to cover the primary header. The edit mode header looks something like:

<gaia-header action="cancel"></gaia-header>

With an added "show|hide" and "transition" configration, we give app developers everything they need to build their own 'edit-mode' header.

NEW ATTRIBUTES

<gaia-header action="cancel" transiton="slide" hide></gaia-header>

NEW PUBLIC API

header.show();
header.hide();
header.toggle();

I'm always in favour of lower-level more primitive configuration as it takes the burden off the component authors and increases flexibily/application, and therefore likelihood of being used.

From the app developer perspective I have seen developers not wanting to implement building blocks when/if they take away to much control. Let's make sure we don't do that :)

	Wilson Page [:wilsonpage]
	Comment 3 • 10 years ago

Comment on attachment 8427068 [details]
patch in github

Looks grand lad! Few nit-picks in Github, nothing major.

Rock on! :)

	Yan Or
	Comment 4 • 10 years ago

I'll defer to Wilson on the CSS.

Can you drop the "data-" prefix on the new show/hide and transition attributes?

	Arnau March [:arnau] ( not working in Firefox OS anymore :( ) Assignee
	Comment 5 • 10 years ago

Merged: dadeed36538bf420612ece7619f8a423df1f7e02