Closed
Bug 1014613
Opened 11 years ago
Closed 11 years ago
media/libstagefright/system/core/include/utils/Errors.h:64:28: error: 'ENODATA' was not declared in this scope (on *BSD platforms)
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: jbeich, Assigned: jbeich)
References
Details
Attachments
(2 files, 1 obsolete file)
|
(deleted),
patch
|
ajones
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
ajones
:
review+
gaston
:
feedback+
|
Details | Diff | Splinter Review |
In file included from media/libstagefright/frameworks/av/media/libstagefright/MetaData.cpp:28:
In file included from media/libstagefright/frameworks/av/include/media/stagefright/MetaData.h:26:
In file included from media/libstagefright/system/core/include/utils/KeyedVector.h:26:
In file included from media/libstagefright/system/core/include/utils/SortedVector.h:26:
In file included from media/libstagefright/system/core/include/utils/Vector.h:26:
In file included from media/libstagefright/system/core/include/utils/VectorImpl.h:23:
media/libstagefright/system/core/include/utils/Errors.h:64:28: error:
use of undeclared identifier 'ENODATA'
NOT_ENOUGH_DATA = -ENODATA,
^
media/libstagefright/frameworks/av/media/libstagefright/MetaData.cpp:298:56: warning:
format specifies type 'int' but the argument has type 'size_t'
(aka 'unsigned long') [-Wformat]
out = String8::format("no type, size %d)", mSize);
~~ ^~~~~
%zu
media/libstagefright/frameworks/av/media/libstagefright/MetaData.cpp:307:53: warning:
format specifies type 'long long' but the argument has type 'int64_t'
(aka 'long') [-Wformat]
out = String8::format("(int64_t) %lld", *(int64_t *)data);
~~~~ ^~~~~~~~~~~~~~~~
%ld
media/libstagefright/frameworks/av/media/libstagefright/MetaData.cpp:324:72: warning:
format specifies type 'int' but the argument has type 'size_t'
(aka 'unsigned long') [-Wformat]
out = String8::format("(unknown type %d, size %d)", mType, mSize);
~~ ^~~~~
%zu
3 warnings and 1 error generated.
In file included from media/libstagefright/Unified_cpp_media_libstagefright1.cpp:28:
In file included from media/libstagefright/frameworks/av/media/libstagefright/id3/ID3.cpp:28:
dist/system_wrappers/byteswap.h:3:15: fatal error: 'byteswap.h' file not found
#include_next <byteswap.h>
^
1 error generated.
In file included from media/libstagefright/Unified_cpp_media_libstagefright0.cpp:41:
In file included from media/libstagefright/binding/mp4_demuxer.cpp:5:
In file included from media/libstagefright/frameworks/av/media/libstagefright/include/MPEG4Extractor.h:23:
media/libstagefright/frameworks/av/include/media/stagefright/DataSource.h:43:28: error:
unknown type name 'off64_t'; did you mean 'off_t'?
virtual ssize_t readAt(off64_t offset, void *data, size_t size) = 0;
^~~~~~~
off_t
/usr/include/stdio.h:53:18: note: 'off_t' declared here
typedef __off_t off_t;
^
In file included from media/libstagefright/Unified_cpp_media_libstagefright0.cpp:41:
In file included from media/libstagefright/binding/mp4_demuxer.cpp:5:
In file included from media/libstagefright/frameworks/av/media/libstagefright/include/MPEG4Extractor.h:23:
media/libstagefright/frameworks/av/include/media/stagefright/DataSource.h:46:20: error:
unknown type name 'off64_t'; did you mean 'off_t'?
bool getUInt16(off64_t offset, uint16_t *x);
^~~~~~~
off_t
/usr/include/stdio.h:53:18: note: 'off_t' declared here
typedef __off_t off_t;
^
In file included from media/libstagefright/Unified_cpp_media_libstagefright0.cpp:41:
In file included from media/libstagefright/binding/mp4_demuxer.cpp:5:
In file included from media/libstagefright/frameworks/av/media/libstagefright/include/MPEG4Extractor.h:23:
media/libstagefright/frameworks/av/include/media/stagefright/DataSource.h:47:20: error:
unknown type name 'off64_t'; did you mean 'off_t'?
bool getUInt24(off64_t offset, uint32_t *x); // 3 byte int, returned as ...
^~~~~~~
off_t
/usr/include/stdio.h:53:18: note: 'off_t' declared here
typedef __off_t off_t;
^
In file included from media/libstagefright/Unified_cpp_media_libstagefright0.cpp:41:
In file included from media/libstagefright/binding/mp4_demuxer.cpp:5:
In file included from media/libstagefright/frameworks/av/media/libstagefright/include/MPEG4Extractor.h:23:
media/libstagefright/frameworks/av/include/media/stagefright/DataSource.h:48:20: error:
unknown type name 'off64_t'; did you mean 'off_t'?
bool getUInt32(off64_t offset, uint32_t *x);
^~~~~~~
off_t
/usr/include/stdio.h:53:18: note: 'off_t' declared here
typedef __off_t off_t;
^
In file included from media/libstagefright/Unified_cpp_media_libstagefright0.cpp:41:
In file included from media/libstagefright/binding/mp4_demuxer.cpp:5:
In file included from media/libstagefright/frameworks/av/media/libstagefright/include/MPEG4Extractor.h:23:
media/libstagefright/frameworks/av/include/media/stagefright/DataSource.h:49:20: error:
unknown type name 'off64_t'; did you mean 'off_t'?
bool getUInt64(off64_t offset, uint64_t *x);
^~~~~~~
off_t
/usr/include/stdio.h:53:18: note: 'off_t' declared here
typedef __off_t off_t;
^
In file included from media/libstagefright/Unified_cpp_media_libstagefright0.cpp:41:
In file included from media/libstagefright/binding/mp4_demuxer.cpp:5:
In file included from media/libstagefright/frameworks/av/media/libstagefright/include/MPEG4Extractor.h:23:
media/libstagefright/frameworks/av/include/media/stagefright/DataSource.h:52:30: error:
unknown type name 'off64_t'; did you mean 'off_t'?
virtual status_t getSize(off64_t *size);
^~~~~~~
off_t
/usr/include/stdio.h:53:18: note: 'off_t' declared here
typedef __off_t off_t;
^
In file included from media/libstagefright/Unified_cpp_media_libstagefright0.cpp:41:
In file included from media/libstagefright/binding/mp4_demuxer.cpp:5:
In file included from media/libstagefright/frameworks/av/media/libstagefright/include/MPEG4Extractor.h:23:
media/libstagefright/frameworks/av/include/media/stagefright/DataSource.h:58:40: error:
unknown type name 'off64_t'; did you mean 'off_t'?
virtual status_t reconnectAtOffset(off64_t offset) {
^~~~~~~
off_t
/usr/include/stdio.h:53:18: note: 'off_t' declared here
typedef __off_t off_t;
^
In file included from media/libstagefright/Unified_cpp_media_libstagefright0.cpp:41:
In file included from media/libstagefright/binding/mp4_demuxer.cpp:5:
media/libstagefright/frameworks/av/media/libstagefright/include/MPEG4Extractor.h:78:5: error:
unknown type name 'off64_t'; did you mean 'off_t'?
off64_t mMoofOffset;
^~~~~~~
off_t
/usr/include/stdio.h:53:18: note: 'off_t' declared here
typedef __off_t off_t;
^
In file included from media/libstagefright/Unified_cpp_media_libstagefright0.cpp:41:
In file included from media/libstagefright/binding/mp4_demuxer.cpp:5:
media/libstagefright/frameworks/av/media/libstagefright/include/MPEG4Extractor.h:97:25: error:
unknown type name 'off64_t'; did you mean 'off_t'?
status_t parseChunk(off64_t *offset, int depth);
^~~~~~~
off_t
/usr/include/stdio.h:53:18: note: 'off_t' declared here
typedef __off_t off_t;
^
In file included from media/libstagefright/Unified_cpp_media_libstagefright0.cpp:41:
In file included from media/libstagefright/binding/mp4_demuxer.cpp:5:
media/libstagefright/frameworks/av/media/libstagefright/include/MPEG4Extractor.h:98:28: error:
unknown type name 'off64_t'; did you mean 'off_t'?
status_t parseMetaData(off64_t offset, size_t size);
^~~~~~~
off_t
/usr/include/stdio.h:53:18: note: 'off_t' declared here
typedef __off_t off_t;
^
In file included from media/libstagefright/Unified_cpp_media_libstagefright0.cpp:41:
In file included from media/libstagefright/binding/mp4_demuxer.cpp:5:
media/libstagefright/frameworks/av/media/libstagefright/include/MPEG4Extractor.h:116:27: error:
unknown type name 'off64_t'; did you mean 'off_t'?
status_t parseDrmSINF(off64_t *offset, off64_t data_offset);
^~~~~~~
off_t
/usr/include/stdio.h:53:18: note: 'off_t' declared here
typedef __off_t off_t;
^
In file included from media/libstagefright/Unified_cpp_media_libstagefright0.cpp:41:
In file included from media/libstagefright/binding/mp4_demuxer.cpp:5:
media/libstagefright/frameworks/av/media/libstagefright/include/MPEG4Extractor.h:116:44: error:
unknown type name 'off64_t'; did you mean 'off_t'?
status_t parseDrmSINF(off64_t *offset, off64_t data_offset);
^~~~~~~
off_t
/usr/include/stdio.h:53:18: note: 'off_t' declared here
typedef __off_t off_t;
^
In file included from media/libstagefright/Unified_cpp_media_libstagefright0.cpp:41:
In file included from media/libstagefright/binding/mp4_demuxer.cpp:5:
media/libstagefright/frameworks/av/media/libstagefright/include/MPEG4Extractor.h:118:31: error:
unknown type name 'off64_t'; did you mean 'off_t'?
status_t parseTrackHeader(off64_t data_offset, off64_t data_size);
^~~~~~~
off_t
/usr/include/stdio.h:53:18: note: 'off_t' declared here
typedef __off_t off_t;
^
In file included from media/libstagefright/Unified_cpp_media_libstagefright0.cpp:41:
In file included from media/libstagefright/binding/mp4_demuxer.cpp:5:
media/libstagefright/frameworks/av/media/libstagefright/include/MPEG4Extractor.h:118:52: error:
unknown type name 'off64_t'; did you mean 'off_t'?
status_t parseTrackHeader(off64_t data_offset, off64_t data_size);
^~~~~~~
off_t
/usr/include/stdio.h:53:18: note: 'off_t' declared here
typedef __off_t off_t;
^
In file included from media/libstagefright/Unified_cpp_media_libstagefright0.cpp:41:
In file included from media/libstagefright/binding/mp4_demuxer.cpp:5:
media/libstagefright/frameworks/av/media/libstagefright/include/MPEG4Extractor.h:120:32: error:
unknown type name 'off64_t'; did you mean 'off_t'?
status_t parseSegmentIndex(off64_t data_offset, size_t data_size);
^~~~~~~
off_t
/usr/include/stdio.h:53:18: note: 'off_t' declared here
typedef __off_t off_t;
^
In file included from media/libstagefright/Unified_cpp_media_libstagefright0.cpp:41:
media/libstagefright/binding/mp4_demuxer.cpp:39:26: error:
unknown type name 'off64_t'; did you mean 'off_t'?
virtual ssize_t readAt(off64_t offset, void* data, size_t size)
^~~~~~~
off_t
/usr/include/stdio.h:53:18: note: 'off_t' declared here
typedef __off_t off_t;
^
In file included from media/libstagefright/Unified_cpp_media_libstagefright0.cpp:41:
media/libstagefright/binding/mp4_demuxer.cpp:53:28: error:
unknown type name 'off64_t'; did you mean 'off_t'?
virtual status_t getSize(off64_t* size)
^~~~~~~
off_t
/usr/include/stdio.h:53:18: note: 'off_t' declared here
typedef __off_t off_t;
^
In file included from media/libstagefright/Unified_cpp_media_libstagefright0.cpp:41:
media/libstagefright/binding/mp4_demuxer.cpp:62:38: error:
unknown type name 'off64_t'; did you mean 'off_t'?
virtual status_t reconnectAtOffset(off64_t offset) { return NO_ERROR; }
^~~~~~~
off_t
/usr/include/stdio.h:53:18: note: 'off_t' declared here
typedef __off_t off_t;
^
In file included from media/libstagefright/Unified_cpp_media_libstagefright0.cpp:54:
In file included from media/libstagefright/frameworks/av/media/libstagefright/DataSource.cpp:17:
media/libstagefright/frameworks/av/media/libstagefright/include/AMRExtractor.h:49:5: error:
unknown type name 'off64_t'; did you mean 'off_t'?
off64_t mOffsetTable[OFFSET_TABLE_LEN]; //5 min
^~~~~~~
off_t
/usr/include/stdio.h:53:18: note: 'off_t' declared here
typedef __off_t off_t;
^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
Attachment #8427058 -
Flags: review?(ajones)
ENOENT is already used, back to 0x80000003 via double negation.
Attachment #8427058 -
Attachment is obsolete: true
Attachment #8427058 -
Flags: review?(ajones)
Attachment #8427079 -
Flags: review?(ajones)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8427079 [details] [diff] [review]
fix
Review of attachment 8427079 [details] [diff] [review]:
-----------------------------------------------------------------
Thank you very much for the patch.
|
|
||
Updated•11 years ago
|
Attachment #8427079 -
Flags: review?(ajones) → review+
|
|
||
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Fwiw, on OpenBSD/sparc64 i've seen a slightly different failure in addition to ENODATA being not declared:
/home/buildslave/mozilla-central-sparc64/build/media/libstagefright/system/core/include/utils/Errors.h:64:28: error: 'ENODATA' was not declared in this scope
NOT_ENOUGH_DATA = -ENODATA,
^
/home/buildslave/mozilla-central-sparc64/build/media/libstagefright/system/core/include/utils/Errors.h:67:28: error: 'EBADMSG' was not declared in this scope
UNKNOWN_TRANSACTION = -EBADMSG,
See http://buildbot.rhaalovely.net/builders/mozilla-central-sparc64/builds/810/steps/build/logs/stdio
I'll followup on this if the failure persists with what was landed.
(In reply to Landry Breuil (:gaston) from comment #4)
> /home/buildslave/mozilla-central-sparc64/build/media/libstagefright/system/
> core/include/utils/Errors.h:67:28: error: 'EBADMSG' was not declared in this
> scope
> UNKNOWN_TRANSACTION = -EBADMSG,
>
Ah, I've skipped testing on OpenBSD because of an ancient in-base compiler and an issue with installing llvm package on 5.4.
Attachment #8427621 -
Flags: review?(ajones)
Attachment #8427621 -
Flags: feedback?(landry)
|
|
||
Comment 6•11 years ago
|
||
Comment on attachment 8427621 [details] [diff] [review]
missed OpenBSD fix
yes libstagefright compiles for me with this.
Attachment #8427621 -
Flags: feedback?(landry) → feedback+
|
||
Comment 7•11 years ago
|
||
Assignee: nobody → jbeich
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
|
|
||
Comment 8•11 years ago
|
||
anthony, review ping for the followup ?
|
|
||
Comment 9•11 years ago
|
||
Not yet fully fixed... adjusting status.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Updated•11 years ago
|
Attachment #8427621 -
Flags: review?(ajones) → review+
|
|
||
Comment 10•11 years ago
|
||
|
|
||
Comment 11•11 years ago
|
||
thanks!
|
|
||
Comment 12•11 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•