Closed
Bug 1014898
Opened 10 years ago
Closed 10 years ago
irregexp: Remove all uses of masm.j()
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: sstangl, Assigned: sstangl)
Details
Attachments
(2 files)
|
(deleted),
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
Separation of comparison from conditional jump is not available on all platforms, specifically MIPS. The helper functions branch32(), branchPtr(), branchTest32(), and branchTestPtr() are preferred for platform-independent code.
Attachment #8427322 -
Flags: review?(bhackett1024)
|
Assignee | |
Comment 1•10 years ago
|
||
mov() is another one of those x86 Assembler functions never intended for generic code -- common code uses move32() and movePtr().
Attachment #8427343 -
Flags: review?(bhackett1024)
|
||
Updated•10 years ago
|
Attachment #8427322 -
Flags: review?(bhackett1024) → review+
|
|
||
Updated•10 years ago
|
Attachment #8427343 -
Flags: review?(bhackett1024) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2bf421d6aa9f
https://hg.mozilla.org/mozilla-central/rev/171cf6341268
Assignee: nobody → sstangl
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•