Closed Bug 1015084 Opened 11 years ago Closed 11 years ago

NfcBuffer unit tests and fixes.

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S3 (6june)

People

(Reporter: kamituel, Assigned: kamituel)

References

Details

Attachments

(1 file)

(deleted), text/x-github-pull-request
alive
: review+
Details
As of current implementation, all 'throw' clauses in nfc_utils.js are throwing strings. We should fix that so they throw proper Error instances.
Summary: NfcUtils and NfcBuffer should throw Error's, not strings. → NfcBuffer unit tests and fixes.
NfcBuffer needs units tests as well.
Attached file Pull request (deleted) —
- Unit tests for NfcBuffer
- NfcBuffer and NfcUtils to throw Error instances instead of plain strings.
Attachment #8427955 - Flags: review?(alive)
Attachment #8427955 - Flags: review?(alive) → review+
Whiteboard: checkin-needed
master: https://github.com/mozilla-b2g/gaia/commit/e508b3fb6fd7a40e78bdff3145eba3dd285c7120
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: checkin-needed
Target Milestone: --- → 2.0 S3 (6june)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: