Closed Bug 1015292 Opened 11 years ago Closed 10 years ago

[Calendar] Update to use gaia-header

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

x86
macOS
defect
Not set
normal

Tracking

(ux-b2g:2.1)

RESOLVED FIXED
ux-b2g 2.1

People

(Reporter: yor, Assigned: wilsonpage)

References

Details

Attachments

(1 file, 1 obsolete file)

(deleted), text/x-github-pull-request
wilsonpage
: review+
Details
No description provided.
Blocks: gaia-header
Assignee: nobody → yor
Status: NEW → ASSIGNED
Attached file PR (obsolete) (deleted) —
Comment on attachment 8473413 [details] PR Rebased to latest master and fixed several bugs. Still looking into a TBPL crash that may not be related but I think we can start the review process.
Attachment #8473413 - Flags: review?(mmedeiros)
Marking this bug for 2.1 since the web components Header is the one committed web component for 2.1. Other web components for 2.2 depend on Header going first. Sorry for doing this late; Hema just brought this bug to my attention today, but it reflects agreed scope and is in the agreed 2.1 plan. Just updating the flags appropriately for release tracking.
ux-b2g: --- → 2.1
Comment on attachment 8473413 [details] PR it's looking good, just a few comments on github. please flag me again after you update the patch. cheers.
Attachment #8473413 - Flags: review?(mmedeiros)
Comment on attachment 8473413 [details] PR Update patch based on feedback. Visual issues will be fixed in the next update of gaia-header.
Attachment #8473413 - Flags: review?(mmedeiros)
Comment on attachment 8473413 [details] PR LGTM! good work.
Attachment #8473413 - Flags: review?(mmedeiros) → review+
Depends on: 1055004
Is this cleared to land? Just checking. :)
I think so. Bug 1055004 seems to occur beyond the gaia-header patches.
Depends on: 1057304
Attached file pull-request (master) (deleted) —
Carrying over r+
Attachment #8479047 - Flags: review+
Attachment #8473413 - Attachment is obsolete: true
Assignee: yor → wilsonpage
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: