Closed
Bug 1015292
Opened 10 years ago
Closed 10 years ago
[Calendar] Update to use gaia-header
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect)
Tracking
(ux-b2g:2.1)
RESOLVED
FIXED
ux-b2g | 2.1 |
People
(Reporter: yor, Assigned: wilsonpage)
References
Details
Attachments
(1 file, 1 obsolete file)
No description provided.
Blocks: gaia-header
Comment on attachment 8473413 [details]
PR
Rebased to latest master and fixed several bugs.
Still looking into a TBPL crash that may not be related but I think we can start the review process.
Attachment #8473413 -
Flags: review?(mmedeiros)
Comment 3•10 years ago
|
||
Marking this bug for 2.1 since the web components Header is the one committed web component for 2.1. Other web components for 2.2 depend on Header going first. Sorry for doing this late; Hema just brought this bug to my attention today, but it reflects agreed scope and is in the agreed 2.1 plan. Just updating the flags appropriately for release tracking.
ux-b2g: --- → 2.1
Comment 4•10 years ago
|
||
Comment on attachment 8473413 [details]
PR
it's looking good, just a few comments on github. please flag me again after you update the patch. cheers.
Attachment #8473413 -
Flags: review?(mmedeiros)
Comment on attachment 8473413 [details]
PR
Update patch based on feedback.
Visual issues will be fixed in the next update of gaia-header.
Attachment #8473413 -
Flags: review?(mmedeiros)
Comment 6•10 years ago
|
||
Comment on attachment 8473413 [details]
PR
LGTM! good work.
Attachment #8473413 -
Flags: review?(mmedeiros) → review+
I think so. Bug 1055004 seems to occur beyond the gaia-header patches.
Assignee | ||
Updated•10 years ago
|
Attachment #8473413 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Assignee: yor → wilsonpage
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8479047 [details] pull-request (master) LANDED https://github.com/mozilla-b2g/gaia/commit/85cd1af363fc0dc3d38adff6ef3e1c6425dc6583
Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•