Closed Bug 1015293 Opened 10 years ago Closed 10 years ago

[Clock] Update to use gaia-header

Categories

(Firefox OS Graveyard :: Gaia::Clock, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Clock
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: yor, Assigned: yor)

References

Details

Attachments

(1 file)

Pull request
(deleted), text/x-github-pull-request
mcav
: review+
wilsonpage
: review+
Details 
      No description provided.
Blocks: gaia-header
Attached file Pull request (deleted) — 

  

  



        Attachment #8428995 -
        Flags: review?(wilsonpage)

        Attachment #8428995 -
        Flags: review?(kgrandon)

    
    

    
  
Comment on attachment 8428995 [details]
Pull request

Please fix travis linter errors and we can have a clock peer review this. Thanks!

  

  



        Attachment #8428995 -
        Flags: review?(kgrandon)

    
  
Assignee: nobody → yor
Status: NEW → ASSIGNED

    
    

    
  
Comment on attachment 8428995 [details]
Pull request

Travis passed.  Please add the appropriate reviewer here.

  

  



        Attachment #8428995 -
        Flags: feedback?(kgrandon)

    
    

    
  
Comment on attachment 8428995 [details]
Pull request

Marcus - could you take a look at this when you have a chance? Thanks!

  

  



        Attachment #8428995 -
        Flags: feedback?(kgrandon) → review?(m)

    
    

    
  
Comment on attachment 8428995 [details]
Pull request

Looks good Yan, you're a machine!

  

  



        Attachment #8428995 -
        Flags: review?(wilsonpage) → review+

        Attachment #8428995 -
        Flags: review?(m) → review+

    
    

    
  
Comment on attachment 8428995 [details]
Pull request

This patch needs updating.

  

  



        Attachment #8428995 -
        Flags: review+

    
    

    
  
As Yan is away, I'll take over this patch.

  

  


Assignee: yor → wilsonpage

    
  
Assignee: wilsonpage → yor

    
  

        Attachment #8428995 -
        Flags: review?(wilsonpage)

        Attachment #8428995 -
        Flags: review?(wilsonpage) → review?(wilsonpage)

        Attachment #8428995 -
        Flags: review?(wilsonpage) → review+

    
    

    
  
Comment on attachment 8428995 [details]
Pull request

LANDED (master) https://github.com/mozilla-b2g/gaia/commit/89b1de05eecd538b368302efc723c1ed84a8b2d3

  

  


Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: