Closed
Bug 1015635
Opened 11 years ago
Closed 8 years ago
Clean up nsObjectLoadingContent::UpdateObjectParameters
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(e10s-)
RESOLVED
INCOMPLETE
| Tracking | Status | |
|---|---|---|
| e10s | - | --- |
People
(Reporter: dzbarsky, Assigned: dzbarsky)
References
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
johns
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
Assignee: nobody → dzbarsky
Attachment #8428288 -
Flags: review?(jschoenick)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Forgot to qref
Attachment #8428288 -
Attachment is obsolete: true
Attachment #8428288 -
Flags: review?(jschoenick)
Attachment #8428289 -
Flags: review?(jschoenick)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8428289 [details] [diff] [review]
Patch
Review of attachment 8428289 [details] [diff] [review]:
-----------------------------------------------------------------
::: content/base/src/nsObjectLoadingContent.cpp
@@ +1475,5 @@
> // bug 853995
> if (isJava) {
> // Find all <param> tags that are nested beneath us, but not beneath another
> // object/applet tag.
> + Element* mydomElement = thisContent->AsElement();
Why not QI to Element in the first place?
@@ +1488,3 @@
> if (domelement) {
> nsAutoString name;
> domelement->GetAttribute(NS_LITERAL_STRING("name"), name);
Element has one that takes an atom
|
|
Assignee | |
Comment 4•11 years ago
|
||
(In reply to :Ms2ger from comment #3)
> Comment on attachment 8428289 [details] [diff] [review]
> Patch
>
> Review of attachment 8428289 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: content/base/src/nsObjectLoadingContent.cpp
> @@ +1475,5 @@
> > // bug 853995
> > if (isJava) {
> > // Find all <param> tags that are nested beneath us, but not beneath another
> > // object/applet tag.
> > + Element* mydomElement = thisContent->AsElement();
>
> Why not QI to Element in the first place?
>
Good point.
> @@ +1488,3 @@
> > if (domelement) {
> > nsAutoString name;
> > domelement->GetAttribute(NS_LITERAL_STRING("name"), name);
>
> Element has one that takes an atom
Fixed.
|
|
Assignee | |
Comment 5•11 years ago
|
||
Attachment #8428289 -
Attachment is obsolete: true
Attachment #8428289 -
Flags: review?(jschoenick)
Attachment #8428303 -
Flags: review?(jschoenick)
|
||
Comment 6•11 years ago
|
||
Comment on attachment 8428303 [details] [diff] [review]
Patch
Review of attachment 8428303 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM
Attachment #8428303 -
Flags: review?(jschoenick) → review+
|
||
Updated•10 years ago
|
tracking-e10s:
--- → -
|
|
Assignee | |
Comment 8•10 years ago
|
||
Sorry, I thought I commented on this before. The patch fails some tests on try and I haven't had time to debug yet.
Flags: needinfo?(dzbarsky)
|
||
Comment 9•8 years ago
|
||
Resolving old bugs which are likely not relevant any more, since NPAPI plugins are deprecated.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INCOMPLETE
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•