Closed
Bug 1015677
Opened 10 years ago
Closed 10 years ago
irregexp: hang without slow script dialog while executing regular expression
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
Tracking | Status | |
---|---|---|
firefox29 | --- | unaffected |
firefox30 | --- | unaffected |
firefox31 | --- | unaffected |
firefox32 | - | affected |
firefox-esr24 | --- | unaffected |
People
(Reporter: alice0775, Assigned: bhackett1024)
References
Details
(Keywords: hang, regression)
Attachments
(1 file)
(deleted),
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #998785 +++
Browser hang up when evaluete the following regular expression.
/<([\w\:]+)((?:[\s\w:=]+|'[^']*'|"[^"]*")*)(?:\/>|>([\d,]*)<\/[^>]+>)/g.test("<rdf:Description rdf:about=\"\" xmlns:test=\"http://test.com/pdf/1.3/\">2,<t>3,</t></rdf:Description>")
Steps To Reproduce:
1. Open "Error Console" (devtools.errorconsole.enabled = true), OR "Browser Console"
2. Evaluate the above code.
Actual Results:
Browser hang up
Expected Results:
Browser should not hang up.
Comment 1•10 years ago
|
||
This isn't related to the Yarr issues: it only happens in builds from after the switch to V8's irregexp engine.
Additionally, executing the same code in the Chrome devtools also causes a hang of the content process, so it seems to happen inside irregexp itself.
Reported upstream at https://code.google.com/p/v8/issues/detail?id=3349.
Assignee | ||
Comment 2•10 years ago
|
||
I guess the ilooping here is an irregexp bug but we shouldn't be hanging. The attached patch checks the interrupt flag on the runtime when backtracking in irregexp, as is done by v8.
Assignee: nobody → bhackett1024
Attachment #8428766 -
Flags: review?(jdemooij)
Flags: needinfo?(bhackett1024)
Updated•10 years ago
|
Attachment #8428766 -
Flags: review?(jdemooij) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Comment 5•10 years ago
|
||
I'm guessing this would impact a small segment of users had this not been fixed. I'm comfortable not tracking this.
Comment 6•10 years ago
|
||
FWIW, dougt actually hit this problem in the wild, albeit on a site somebody posted as an example of browsers taking up a ridiculous amount of CPU.
Updated•10 years ago
|
QA Whiteboard: [good first verify]
You need to log in
before you can comment on or make changes to this bug.
Description
•