This also removes the BOM from the following files: dom/media/tests/mochitest/head.js dom/media/tests/mochitest/mediaStreamPlayback.js dom/media/tests/mochitest/pc.js mozglue/build/fixcrt.py The patch was produced with: ag -l 'This Source Code Form is subject to the terms of the Mozilla Public' \ xargs dos2unix As a result, files with a missing/different copyright header have not been converted. Try push: https://tbpl.mozilla.org/?tree=Try&rev=b70bd47bcf4a

Should this be checked into the NSS repo?

Comment on attachment 8429196 [details] [diff] [review] Exterminate CR+LF line endings Review of attachment 8429196 [details] [diff] [review]: ----------------------------------------------------------------- So in the past at least in the case of the media code here, people had told me to not change the line endings. Because of that reason, I sort of hesitate to give a blanket r+ here, so I'm forwarding the request for the media code to cpearce and the browser/toolkit parts to gavin and the security parts to bsmith. r=me on the rest of the bits and pieces in between.

(In reply to Birunthan Mohanathas [:poiru] from comment #2) > Created attachment 8429198 [details] [diff] [review] > Exterminate CR+LF line endings in NSS > > Should this be checked into the NSS repo? I suggest you move the NSS part into a different bug in the NSS product, as that code is not really owned by us, and patches should be checked in to the upstream repo first, and we usually take periodic updates from it later.

Comment on attachment 8429196 [details] [diff] [review] Exterminate CR+LF line endings rs=briansmith for the PSM bits. I didn't look at the patch but there's nothing in PSM that requires CRLF. Also, I've updated my .hgeol to be: [repository] native = LF so that it is unlikely we'll add new CRLFs into PSM.

Comment on attachment 8429196 [details] [diff] [review] Exterminate CR+LF line endings Review of attachment 8429196 [details] [diff] [review]: ----------------------------------------------------------------- Fine. Whatever. Stop bugging me about my inferior line endings. ::: CLOBBER @@ +21,5 @@ > # Are you updating CLOBBER because you think it's needed for your WebIDL > # changes to stick? As of bug 928195, this shouldn't be necessary! Please > # don't change CLOBBER for WebIDL changes any more. > > +Bug 1016240 requires a clobber No bull?

Oh yeah, please don't touch the CLOBBER file in this patch.

Comment on attachment 8429196 [details] [diff] [review] Exterminate CR+LF line endings rs=me based on scanning the browser/ file list.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca251a28d3dd (In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment #4) > (In reply to Birunthan Mohanathas [:poiru] from comment #2) > > Created attachment 8429198 [details] [diff] [review] > > Exterminate CR+LF line endings in NSS > > > > Should this be checked into the NSS repo? > > I suggest you move the NSS part into a different bug in the NSS product, as > that code is not really owned by us, and patches should be checked in to the > upstream repo first, and we usually take periodic updates from it later. Will do.

Comment on attachment 8429198 [details] [diff] [review] Exterminate CR+LF line endings in NSS I didn't see an NSS bug for this patch, so I'm just going to use this bug. r=wtc. Patch checked in: https://hg.mozilla.org/projects/nss/rev/777ff0acc9e8

Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f38dc9833eb6 No bug - Ignore bug 1016240 in blame/annotate. r=MattN