Closed
Bug 1016345
Opened 11 years ago
Closed 10 years ago
Add memory reporting for nsHTMLCSSStyleSheet's nsDataHashtable's buffer and the buffers of its nsString keys
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: jwatt, Assigned: jwatt)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [MemShrink:P2])
Attachments
(1 file)
|
(deleted),
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
We're not accounting for several KBs of memory due to not accounting for nsHTMLCSSStyleSheet's nsDataHashtable's buffer and the buffers of its nsString keys.
|
Assignee | |
Comment 1•11 years ago
|
||
Typically, that is. Obviously the amount varies depending on the document.
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #8429247 -
Flags: review?(n.nethercote)
|
||
Updated•11 years ago
|
Whiteboard: [MemShrink]
|
|
||
Updated•11 years ago
|
Whiteboard: [MemShrink] → [MemShrink:P2]
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8429247 [details] [diff] [review]
patch
Review of attachment 8429247 [details] [diff] [review]:
-----------------------------------------------------------------
dbaron is a better reviewer of this change.
(I'm good at reviewing memory reporters themselves, but the SizeOf() functions used by those memory reporters often go into areas I don't know much about, and so domain experts can often evaluate them better. If in doubt, feel free to r? me and I can forward if necessary.)
Attachment #8429247 -
Flags: review?(n.nethercote) → review?(dbaron)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8429247 [details] [diff] [review]
patch
r=dbaron. Sorry for the delay.
Attachment #8429247 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
|
||
Comment 6•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•