Closed
Bug 1016377
Opened 11 years ago
Closed 10 years ago
[NFC] NfcManager.handleTechnologyDiscovered should properly handle malformed messages
Categories
(Firefox OS Graveyard :: NFC, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S3 (6june)
People
(Reporter: tauzen, Assigned: tauzen)
References
Details
(Whiteboard: [p=1])
Attachments
(1 file)
NfcManager.handleTechologyDiscovered(command) is a message handler for 'nfc-manager-tech-discovered' message. If the message will not be an object containing techList array this method will throw the following errors: - "TypeError: command is null", if message is null - "TypeError: techList is undefined", if message does not contain techList property - "TypeError: techList.sort is not a function", if techList is not an array (actually this is thrown in different method, which expects to get an array as an argument) This message originates from nfc_worker.js and is passed to Nfc.js which after some modifications sends it to NfcManager. I think we should assume that somewhere on the processing path the message might be malformed. Also i would propose to rename command to be consistent with the naming in lower layers.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → kmioduszewski
Assignee | ||
Updated•11 years ago
|
Updated•10 years ago
|
Attachment #8430094 -
Flags: review?(alive) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 2•10 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/d42c6abc29e90d0985d260f538e453f516d05b22
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S3 (6june)
Assignee | ||
Updated•10 years ago
|
Whiteboard: [p=1]
You need to log in
before you can comment on or make changes to this bug.
Description
•