Closed Bug 1016442 Opened 10 years ago Closed 10 years ago

Make mozilla cdn sites production on built-in pins

Categories

(Core :: Security: PSM, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: cviecco, Assigned: cviecco)

References

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Telemetry shows mozilla sites OK, so it is time to start making them into production (starting with low risk).
Attached patch pin-update1 (obsolete) (deleted) — Splinter Review
Attachment #8429399 - Flags: review?(mmc)
Comment on attachment 8429399 [details] [diff] [review] pin-update1 Review of attachment 8429399 [details] [diff] [review]: ----------------------------------------------------------------- ::: security/manager/tools/PreloadedHPKPins.json @@ +176,1 @@ > "pins": "mozilla", "test_mode": true, "id": 2 }, According to bsmedberg and taras, we cannot keep individual telemetry for this bucket (not that it would tell us much anyway). Please remove the id field.
Attachment #8429399 - Flags: review?(mmc) → review-
Comment on attachment 8429399 [details] [diff] [review] pin-update1 Review of attachment 8429399 [details] [diff] [review]: ----------------------------------------------------------------- ::: security/manager/tools/PreloadedHPKPins.json @@ +176,1 @@ > "pins": "mozilla", "test_mode": true, "id": 2 }, a). Let's do this in a separate bug. b). What's the relationship between addons.mozilla.net and mozilla.net? As I understand it, the former is necessary for the proper functioning of the browser, and so it can have a specific telemetry id. If the latter is just a cdn, depending on what it serves, I don't think we can give it a telemetry id.
Attachment #8429399 - Flags: review- → review?(mmc)
Comment on attachment 8429399 [details] [diff] [review] pin-update1 Ugh. Bugzilla.
Attachment #8429399 - Flags: review?(mmc) → review-
Summary: Make mozilla cdn sites production on built-in pins and change test domain addons.mozilla.net to mozilla.net → Make mozilla cdn sites production on built-in pins
(In reply to David Keeler (:keeler) [use needinfo?] from comment #4) > Comment on attachment 8429399 [details] [diff] [review] > pin-update1 > > Review of attachment 8429399 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: security/manager/tools/PreloadedHPKPins.json > @@ +176,1 @@ > > "pins": "mozilla", "test_mode": true, "id": 2 }, > > a). Let's do this in a separate bug. My bad -- Camilo came by and I asked him to do everything in 1 bug because I didn't want any sites to be double-counted (or left out) in the stats.
Attached patch pin-update1 (v2) (obsolete) (deleted) — Splinter Review
Attachment #8429399 - Attachment is obsolete: true
Attachment #8429413 - Flags: review?(mmc)
Attachment #8429413 - Flags: review?(mmc) → review+
Comment on attachment 8429413 [details] [diff] [review] pin-update1 (v2) Review of attachment 8429413 [details] [diff] [review]: ----------------------------------------------------------------- ::: security/manager/tools/PreloadedHPKPins.json @@ +176,5 @@ > "pins": "mozilla", "test_mode": true, "id": 2 }, > { "name": "aus4.mozilla.org", "include_subdomains": true, > "pins": "mozilla", "test_mode": true, "id": 3 }, > { "name": "cdn.mozilla.net", "include_subdomains": true, > + "pins": "mozilla", "test_mode": false}, nit: space after false
Attached patch pin-update1 (v3) (deleted) — Splinter Review
Keeping r+ from mmc
Attachment #8429413 - Attachment is obsolete: true
Attachment #8429417 - Flags: review+
Assignee: nobody → cviecco
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: