Closed
Bug 1016496
Opened 11 years ago
Closed 7 years ago
Logout does not ask for confirmation
Categories
(Firefox OS Graveyard :: FxA, defect, P3)
Tracking
(blocking-b2g:-)
RESOLVED
WONTFIX
blocking-b2g | - |
People
(Reporter: njpark, Unassigned)
References
Details
(Whiteboard: [fxa4fxos2.0])
STR:
Log in to firefox accounts
Log out from firefox accounts in Settings -> Firefox accounts dialog
Expected:
Per Bug 949100, the user should be presented with the confirmation dialog and a warning message.
Actual:
Logout is completed without any warning message.
Version Info:
│ Gaia c8f6ba7aa9a694f5f691555a0d049f5630cdde3d │
│ Gecko │
│ https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/bde42427e332 │
│ BuildID 20140527014007 │
│ Version 28.1 │
│ ro.build.version.incremental=301
Reporter | ||
Updated•11 years ago
|
Reporter | ||
Updated•11 years ago
|
Assignee: nobody → 6a68
Reporter | ||
Updated•11 years ago
|
blocking-b2g: --- → 2.0?
Updated•10 years ago
|
Flags: needinfo?(jgruen)
Updated•10 years ago
|
Flags: needinfo?(jgruen)
Comment 3•10 years ago
|
||
Looks like this will require a little bit of Gecko work to land.
I've tried reusing the existing refreshAuthentication screen/IAC command, but if there's an active session, Gecko throws an ERROR_ALREADY_LOGGED_IN_USER without checking the password.
To be discussed with spenrose or ferjm when those guys are back from PTO.
Flags: needinfo?(spenrose)
Flags: needinfo?(ferjmoreno)
Updated•10 years ago
|
Summary: [FxAccount] Logout does not ask for confirmation → Logout does not ask for confirmation
Comment 4•10 years ago
|
||
(In reply to Jared Hirsch [:_6a68] [@6a68] from comment #3)
> Looks like this will require a little bit of Gecko work to land.
>
> I've tried reusing the existing refreshAuthentication screen/IAC command,
> but if there's an active session, Gecko throws an
> ERROR_ALREADY_LOGGED_IN_USER without checking the password.
>
> To be discussed with spenrose or ferjm when those guys are back from PTO.
Hi Jared,
I believe in this case we shouldn't reuse the refreshAuthentication screen or its IAC command, but instead keep using the current 'logout' IAC command [1] and create a new logout screen (note that we already have a way to trigger such a screen via FxAccountsUI.logout [2] but we don't have the screen itself). Also note that the US at [3] is not specifying that the user should be asked to introduce any password but the description of [4] does, so this new screen should be able to provide both options.
As you said, it seems that we also need some Gecko work for [4] as we need to verify the password before logging the user out. I think that we can simply add the password to the FxAClient.logout call [5] and let Gecko do the verification. On the Gaia side we would need to listen for the 'onlogout' event [6].
[1] https://mxr.mozilla.org/gaia/source/apps/system/js/fxa_manager.js#81
[2] https://mxr.mozilla.org/gaia/source/apps/system/js/fxa_ui.js#31
[3] https://bugzilla.mozilla.org/show_bug.cgi?id=949100#c0
[4] https://bugzilla.mozilla.org/show_bug.cgi?id=1055249#c0
[5] https://mxr.mozilla.org/gaia/source/apps/system/js/fxa_client.js#85
[6] https://mxr.mozilla.org/gaia/source/apps/system/js/fxa_manager.js#168
Flags: needinfo?(spenrose)
Flags: needinfo?(ferjmoreno)
Updated•7 years ago
|
Assignee: jhirsch → nobody
Comment 5•7 years ago
|
||
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•