Closed
Bug 1016816
Opened 10 years ago
Closed 10 years ago
[CostControl] Update to use gaia-header
Categories
(Firefox OS Graveyard :: Gaia::Cost Control, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: yor, Assigned: wilsonpage)
References
Details
Attachments
(1 file, 2 obsolete files)
No description provided.
Blocks: gaia-header
Attachment #8431325 -
Flags: review?(salva)
Attachment #8431325 -
Flags: review?(21)
Comment 2•10 years ago
|
||
Comment on attachment 8431325 [details]
Pull Request
Moving to JM.
Attachment #8431325 -
Flags: review?(salva)
Attachment #8431325 -
Flags: review?(jmcf)
Attachment #8431325 -
Flags: review?(21)
Comment 3•10 years ago
|
||
Comment on attachment 8431325 [details]
Pull Request
Apart from the comments on GH the position of the settings icon in the main header app is incorrect. Please check
Attachment #8431325 -
Flags: review?(jmcf) → review-
Assignee | ||
Updated•10 years ago
|
Attachment #8467153 -
Flags: review?(jmcf)
Assignee | ||
Comment 5•10 years ago
|
||
Updated this patch to use the new shared setup.
Assignee: yor → wilsonpage
Updated•10 years ago
|
Attachment #8467153 -
Flags: review?(jmcf) → review?(mri)
Comment 6•10 years ago
|
||
Comment on attachment 8467153 [details]
pull-request (master)
After install the patch I can see the following errors on the console:
E/GeckoConsole( 790): [JavaScript Warning: "Unknown property 'speak'. Declaration dropped." {file: "app://costcontrol.gaiamobile.org/shared/elements/gaia-icons/style.css" line: 21 column: 6 source: " speak:none;"}]
E/GeckoConsole( 790): [JavaScript Warning: "Unknown property '-moz-osx-font-smoothing'. Declaration dropped." {file: "app://costcontrol.gaiamobile.org/shared/elements/gaia-icons/style.css" line: 27 column: 24 source: " -moz-osx-font-smoothing:grayscale;"}]
Please, addressing this here or openning a new bug to fix it.
r+ for me, please correct the nits on GH. Works well, thank you.
Attachment #8467153 -
Flags: review?(mri) → review+
Assignee | ||
Comment 7•10 years ago
|
||
mai: I'm having issues with unit-tests. Can you try running locally and diagnose what's causing them to fail?
Flags: needinfo?(mri)
Assignee | ||
Comment 9•10 years ago
|
||
Comment on attachment 8467153 [details] pull-request (master) LANDED https://github.com/mozilla-b2g/gaia/commit/9d4fb86e980100a09ae0d181f4234d8ef8c6ea5e
Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 10•10 years ago
|
||
Backed out for causing linter failures: https://github.com/mozilla-b2g/gaia/commit/a2219a55145e730e56e09527b40152d68a43b0d9 https://travis-ci.org/mozilla-b2g/gaia/jobs/32451857
Status: RESOLVED → REOPENED
Flags: needinfo?(yor)
Resolution: FIXED → ---
Comment 11•10 years ago
|
||
TBPL is currently down and trees are closed, but maybe we only have to update the xfail count here? I can help dig into this later today if you guys don't get to it.
Assignee | ||
Comment 12•10 years ago
|
||
Comment on attachment 8467153 [details]
pull-request (master)
UPDATED
- Fixed CSSLint failure.
---
This was due to CSSLint recently being turned on on TBPL (after initial TBPL green). I'll wait for green and re-land.
Assignee | ||
Comment 14•10 years ago
|
||
Comment on attachment 8472449 [details]
pull-request (master)
Carrying across previous r+
Attachment #8472449 -
Flags: review+
Assignee | ||
Comment 15•10 years ago
|
||
Comment on attachment 8472449 [details] pull-request (master) LANDED https://github.com/mozilla-b2g/gaia/commit/df6081e437446e85433aff4ee19f7c8b2b4875a6
Assignee | ||
Updated•10 years ago
|
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•