Closed
Bug 1016818
Opened 10 years ago
Closed 10 years ago
[Bluetooth] Update to use gaia-header
Categories
(Firefox OS Graveyard :: Gaia::Bluetooth, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: yor, Assigned: yor)
References
Details
Attachments
(1 file)
No description provided.
Blocks: gaia-header
Comment 2•10 years ago
|
||
Comment on attachment 8429838 [details] Pull request Hey, you should probably use the modules page (https://wiki.mozilla.org/Modules/FirefoxOS) to find the right reviewer, or use the history in github of the repo. In this case, I think it would make sense for Ian to review this perhaps. Ian - could you please take a look at this? If you don't have time, feel free to delegate to me. Thanks!
Attachment #8429838 -
Flags: review?(kgrandon) → review?(iliu)
Comment 3•10 years ago
|
||
Comment on attachment 8429838 [details]
Pull request
Hi Yan,
I leave some comment on GitHub. Since we set the header property 'hidden' dynamically, the tag 'gaia-subheader' is not working for the original property operation. So we always see the showing header 'Paired devices' when no device are paired. Shell the component plan to have the ability? Thanks.
Attachment #8429838 -
Flags: review?(iliu)
Comment on attachment 8429838 [details]
Pull request
Hi Ian,
Resync the patch with the latest base and added support for 'hidden' in gaia-subheader. Please review. Thanks.
Attachment #8429838 -
Flags: review?(iliu)
Comment 5•10 years ago
|
||
Comment on attachment 8429838 [details]
Pull request
Yan, the patch looks good for me without a nit on Github. Please check the comment on Github. Thanks. r=me
Attachment #8429838 -
Flags: review?(iliu) → review+
Comment 7•10 years ago
|
||
Comment on attachment 8429838 [details] Pull request LANDED (master) https://github.com/mozilla-b2g/gaia/commit/859f927016382b445e3b0005a60f5529dd4e5bd5
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•