Closed Bug 1016852 Opened 11 years ago Closed 10 years ago

[Contacts] Intermitent test in navigation

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

defect
Not set
normal

Tracking

(b2g-v1.4 affected, b2g-v2.0 ?)

RESOLVED FIXED
Tracking Status
b2g-v1.4 --- affected
b2g-v2.0 --- ?

People

(Reporter: arcturus, Assigned: julienw)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

(deleted), text/x-github-pull-request
Details
Jose could you take a look? Thanks!
Flags: needinfo?(jmcf)
Note that this is in v1.4.
Travis is permared on v1.4 because of this, Francisco, can you please backout whatever did this?
Flags: needinfo?(francisco)
Germán will be taking a look this morning. If we don't find a quick fix I would suggest we skip that test
Flags: needinfo?(jmcf)
What's the status for this?
Flags: needinfo?(francisco) → needinfo?(gtorodelvalle)
First failing Travis build is https://travis-ci.org/mozilla-b2g/gaia/jobs/26181184 It's completely unrelated so IMO this shows that there is probably a Firefox change. Maybe we should fetch the correct Firefox version for this branch? I filed a separate bug for this: bug 1018896. But I'd like to know why this does not fail in master? Is the test different?
Taking a look to this, 1.4 shouldn't be red :(
Assignee: nobody → francisco
So, same Firefox, v1.4 fails, master works. I added logs in both tests that spy on window.parent.postMessage, and... * in master, window.parent.postMessage is always null: in both tests, before and after the spying * in v1.4, window.parent.postMessage is "normal" before the first spy, then it's a sinon spy after the first spy (in the first test); then it's undefined in the second test before the second spy. I also added logs in test-agent's sinon_helper.js on v1.4, and I saw that window.parent.postMessage turns to "undefined" after restoring sinon's sandbox. I don't see what changed in https://travis-ci.org/mozilla-b2g/gaia/jobs/26181184 However, we have different sinon versions between 1.4 and master, so I'll try this now.
upgrading sinon seems to work, I'll prepare a PR.
Attached file github PR (deleted) —
Let's see how Travis like this before requesting a review. I _still_ don't know what changed to make this red, though.
Assignee: francisco → felash
Flags: needinfo?(gtorodelvalle)
Fixed by uplifting bug 995425 (I don't know what the main issue was, and I don't really care)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: