Carol Huang [:Carol] Reporter
	Description • 10 years ago

Base on Pavel's feedback, there's some missing images that need to update.

	Carol Huang [:Carol] Reporter
	Comment 1 • 10 years ago

Hi Pavel,
I attached 4 missing images that need to update.
thanks!

./apps/settings/style/images/document_bg@2.25x.png
./apps/settings/style/images/feedback_faces@1.5x.png
./apps/settings/style/images/feedback_faces@2x.png
./apps/settings/style/images/simcards@2x.png

	Carol Huang [:Carol] Reporter
	Comment 2 • 10 years ago

Hey Pavel,
The images list below are only 1 size, so they are not "missing". Could be ignored. thanks :)

./apps/settings/style/images/icon/back_tablet@1.5x.png
./apps/settings/style/images/icon/back_tablet@2x.png
./apps/settings/style/images/icon/back_tablet@2.25x.png
./apps/settings/style/images/ui/tablet_button_separator@1.5x.png
./apps/settings/style/images/ui/tablet_button_separator@2x.png
./apps/settings/style/images/ui/tablet_button_separator@2.25x.png
./apps/settings/style/images/ui/tablet_header@1.5x.png
./apps/settings/style/images/ui/tablet_header@2x.png
./apps/settings/style/images/ui/tablet_header@2.25x.png
./apps/settings/style/images/ui/tablet_header_pressed@1.5x.png
./apps/settings/style/images/ui/tablet_header_pressed@2x.png
./apps/settings/style/images/ui/tablet_header_pressed@2.25x.png
./apps/settings/style/images/ui/tablet_menu_header@1.5x.png
./apps/settings/style/images/ui/tablet_menu_header@2x.png
./apps/settings/style/images/ui/tablet_menu_header@2.25x.png
./apps/settings/style/images/ui/tablet_separator@1.5x.png
./apps/settings/style/images/ui/tablet_separator@2x.png
./apps/settings/style/images/ui/tablet_separator@2.25x.png

	Carol Huang [:Carol] Reporter
	Comment 3 • 10 years ago

// Please change the naming below
Settings_60.png to Settings.png
Settings_90.png to Settings@1.5x
Settings_120.png to Settings@2x.png
Settings_135.png to Settings@2.25x.png

--
These images list below dont exist. It's the naming problem. can be ignored(removed).
Thanks!!

APP icon./apps/settings/style/icons/Settings_120@1.5x.png
App icon./apps/settings/style/icons/Settings_120@2x.png
APP icon./apps/settings/style/icons/Settings_120@2.25x.png
APP icon./apps/settings/style/icons/Settings_135@1.5x.png
APP icon./apps/settings/style/icons/Settings_135@2x.png
APP icon./apps/settings/style/icons/Settings_135@2.25x.png
APP icon./apps/settings/style/icons/Settings_60@1.5x.png
App icon./apps/settings/style/icons/Settings_60@2x.png
App icon./apps/settings/style/icons/Settings_60@2.25x.png
App icon./apps/settings/style/icons/Settings_90@1.5x.png
APP icon./apps/settings/style/icons/Settings_90@2x.png
APP icon./apps/settings/style/icons/Settings_90@2.25x.png

	Pavel Ivanov [:ivanovpavel][:pivanov] UX
	Comment 4 • 10 years ago

Hey Carol,
thanks for the images :)

About non existing images ... I check each image on the gaia/master and that's why some of the results are not valid and as you say they can be ignored :) Thanks again :)

	:gerard-majax [PTO 01/08/2023-10/09/2023]
	Comment 7 • 10 years ago

I had reported this already several days ago in  bug 1015170 ...

	Evelyn Hung
	Comment 8 • 10 years ago

Comment on attachment 8430247 [details]
patch for Gaia/master

Thanks!

	Evelyn Hung
	Comment 9 • 10 years ago

Merged into master
https://github.com/mozilla-b2g/gaia/commit/eced604040a970e65dfb51fa83e1a18a9d00b7db

	Sherman Chen [:chens] (inactive)
	Comment 10 • 10 years ago

We should avoid using @*x postfix naming in the manifest. Because during build time, build system will remove all images with @*x postfix and keep only one correct resource based on device pixel ratio.
Thus in the icon folder for Settings app will keep only one icon, which is "Settings.png", and it will cause error once homescreen needs to retrieve larger icon for it.

	Pavel Ivanov [:ivanovpavel][:pivanov] UX
	Comment 11 • 10 years ago

Hey Sherman,
so we need to keep Settings.png and variations like Settings_60.png Settings_90.png etc. right?

	Sherman Chen [:chens] (inactive)
	Comment 12 • 10 years ago

(In reply to Pavel Ivanov [:ivanovpavel] from comment #11)
> Hey Sherman,
> so we need to keep Settings.png and variations like Settings_60.png
> Settings_90.png etc. right?

Yes, IMHO we should keep them like Settings_60.png, Settings_90.png, etc.

	Pavel Ivanov [:ivanovpavel][:pivanov] UX
	Comment 13 • 10 years ago

Hey Evelyn,
we need to change the icon file names

	Michael Henretty [:mikehenrty][:mhenretty]
	Comment 14 • 10 years ago

Backed out for causing settings regression, bug 1018183.

master: https://github.com/mozilla-b2g/gaia/commit/eb58392c0c70a177fc4d3e140d25f53320d54cf8

	Evelyn Hung
	Comment 15 • 10 years ago

Comment on attachment 8431507 [details]
follow-up patch for Gaia/master

Thanks for catching up, Sherman. Also thanks for the follow-up patch.

	Evelyn Hung
	Comment 16 • 10 years ago

merged again:
https://github.com/mozilla-b2g/gaia/commit/fc33df179fa55bb10a64d9aa191afc4de14a1308